Skip to content

Commit 5b89bd2

Browse files
committed
Java: Deprecate the content of SqlTaintedLocalQuery and remove the local query variant.
1 parent b68abab commit 5b89bd2

File tree

7 files changed

+11
-32
lines changed

7 files changed

+11
-32
lines changed

java/ql/lib/semmle/code/java/security/SqlTaintedLocalQuery.qll

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ private import semmle.code.java.security.Sanitizers
1212
* A taint-tracking configuration for reasoning about local user input that is
1313
* used in a SQL query.
1414
*/
15-
module LocalUserInputToQueryInjectionFlowConfig implements DataFlow::ConfigSig {
15+
deprecated module LocalUserInputToQueryInjectionFlowConfig implements DataFlow::ConfigSig {
1616
predicate isSource(DataFlow::Node src) { src instanceof LocalUserInput }
1717

1818
predicate isSink(DataFlow::Node sink) { sink instanceof QueryInjectionSink }
@@ -25,7 +25,9 @@ module LocalUserInputToQueryInjectionFlowConfig implements DataFlow::ConfigSig {
2525
}
2626

2727
/**
28+
* DEPRECATED: Use `QueryInjectionFlow` instead and configure threat model sources to include `local`.
29+
*
2830
* Taint-tracking flow for local user input that is used in a SQL query.
2931
*/
30-
module LocalUserInputToQueryInjectionFlow =
32+
deprecated module LocalUserInputToQueryInjectionFlow =
3133
TaintTracking::Global<LocalUserInputToQueryInjectionFlowConfig>;

java/ql/src/Security/CWE/CWE-089/SqlTaintedLocal.qhelp

Lines changed: 0 additions & 5 deletions
This file was deleted.

java/ql/src/Security/CWE/CWE-089/SqlTaintedLocal.ql

Lines changed: 0 additions & 24 deletions
This file was deleted.
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
extensions:
2+
- addsTo:
3+
pack: codeql/threat-models
4+
extensible: threatModelConfiguration
5+
data:
6+
- ["local", true, 0]
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Security/CWE/CWE-089/SqlTainted.ql

java/ql/test/query-tests/security/CWE-089/semmle/examples/SqlTaintedLocal.qlref

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)