Skip to content

Commit 61c7236

Browse files
committed
move the "isFileTooLarge" earlier in the pipeline, so we're only doing it once
1 parent 241f977 commit 61c7236

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

javascript/extractor/src/com/semmle/js/extractor/AutoBuild.java

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -735,6 +735,7 @@ private CompletableFuture<?> extractSource() throws IOException {
735735
.collect(Collectors.toList());
736736

737737
filesToExtract = filesToExtract.stream()
738+
.filter(p -> !isFileTooLarge(p))
738739
.sorted(PATH_ORDERING)
739740
.collect(Collectors.toCollection(() -> new LinkedHashSet<>()));
740741

@@ -1063,9 +1064,6 @@ private Set<Path> extractTypeScript(
10631064
if (extractedFiles.contains(sourcePath)) {
10641065
continue;
10651066
}
1066-
if (isFileTooLarge(sourcePath)) {
1067-
continue;
1068-
}
10691067
typeScriptFiles.add(sourcePath);
10701068
}
10711069
typeScriptFiles.sort(PATH_ORDERING);
@@ -1083,8 +1081,7 @@ private Set<Path> extractTypeScript(
10831081
List<Path> remainingTypeScriptFiles = new ArrayList<>();
10841082
for (Path f : files) {
10851083
if (!extractedFiles.contains(f)
1086-
&& extractors.fileType(f) == FileType.TYPESCRIPT
1087-
&& !isFileTooLarge(f)) {
1084+
&& extractors.fileType(f) == FileType.TYPESCRIPT) {
10881085
remainingTypeScriptFiles.add(f);
10891086
}
10901087
}
@@ -1250,9 +1247,6 @@ private void doExtract(FileExtractor extractor, Path file, ExtractorState state)
12501247
warn("Skipping " + file + ", which does not exist.");
12511248
return;
12521249
}
1253-
if (isFileTooLarge(file)) {
1254-
return;
1255-
}
12561250

12571251
try {
12581252
long start = logBeginProcess("Extracting " + file);

0 commit comments

Comments
 (0)