Skip to content

Commit 632cce2

Browse files
committed
JS: Add failing test due to overpruning
1 parent 43abc72 commit 632cce2

File tree

3 files changed

+18
-0
lines changed

3 files changed

+18
-0
lines changed

javascript/ql/test/library-tests/frameworks/data/test.expected

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
consistencyIssue
2+
| library-tests/frameworks/data/test.js:261 | expected an alert, but found none | NOT OK | |
23
taintFlow
34
| paramDecorator.ts:6:54:6:54 | x | paramDecorator.ts:7:10:7:10 | x |
45
| test.js:5:30:5:37 | source() | test.js:5:8:5:38 | testlib ... urce()) |

javascript/ql/test/library-tests/frameworks/data/test.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,3 +272,9 @@ class MySubclass2 extends MySubclass {
272272
sink(new MySubclass2().baseclassSource()); // NOT OK
273273

274274
sink(testlib.parenthesizedPackageName()); // NOT OK
275+
276+
function dangerConstant() {
277+
sink("danger-constant".danger); // NOT OK
278+
sink("danger-constant".safe); // OK
279+
sink("danger-constant"); // OK
280+
}

javascript/ql/test/library-tests/frameworks/data/test.ql

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,17 @@ import javascript
22
import testUtilities.ConsistencyChecking
33
import semmle.javascript.frameworks.data.internal.ApiGraphModels as ApiGraphModels
44

5+
class TypeModelFromCodeQL extends ModelInput::TypeModel {
6+
override DataFlow::Node getASource(string type) {
7+
type = "danger-constant" and
8+
result.getStringValue() = "danger-constant"
9+
}
10+
}
11+
12+
class SourceFromDangerConstant extends ModelInput::SourceModelCsv {
13+
override predicate row(string row) { row = "danger-constant;Member[danger];test-source" }
14+
}
15+
516
class BasicTaintTracking extends TaintTracking::Configuration {
617
BasicTaintTracking() { this = "BasicTaintTracking" }
718

0 commit comments

Comments
 (0)