change Source to ConstantString, it seems that we have some duplicate results now, ConstantString is suggested as a better alternative for finding constant sources

am0o0 · am0o0 · commit 7a577ddd982b · 2023-08-30T20:47:43.000+10:00
diff --git a/javascript/ql/src/Security/CWE-321-HardCodedKey/jwtConstantKey.ql b/javascript/ql/src/Security/CWE-321-HardCodedKey/jwtConstantKey.ql
@@ -18,7 +18,7 @@ class JWTDecodeConfig extends TaintTracking::Configuration {
   JWTDecodeConfig() { this = "JWTConfig" }
 
   override predicate isSource(DataFlow::Node source) {
-    source.asExpr() instanceof StringLiteral or source.asExpr() instanceof TemplateLiteral
+    source.asExpr() instanceof ConstantString 
   }
 
   override predicate isSink(DataFlow::Node sink) {

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ class JWTDecodeConfig extends TaintTracking::Configuration {`
`18`	`18`	`JWTDecodeConfig() { this = "JWTConfig" }`
`19`	`19`
`20`	`20`	`override predicate isSource(DataFlow::Node source) {`
`21`		`- source.asExpr() instanceof StringLiteral or source.asExpr() instanceof TemplateLiteral`
	`21`	`+ source.asExpr() instanceof ConstantString`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`override predicate isSink(DataFlow::Node sink) {`