Skip to content

Commit 8108c72

Browse files
committed
C#: Exclude structs from being flagged in cs/missed-readonly-modifier.
1 parent 28cd8a8 commit 8108c72

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

csharp/ql/src/Language Abuse/MissedReadonlyOpportunity.ql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ predicate isReadonlyCompatibleDefinition(AssignableDefinition def, Field f) {
2727
}
2828

2929
predicate canBeReadonly(Field f) {
30+
exists(Type t | t = f.getType() | not t instanceof Struct or t.(Struct).isReadonly()) and
3031
forex(AssignableDefinition def | defTargetsField(def, f) | isReadonlyCompatibleDefinition(def, f))
3132
}
3233

0 commit comments

Comments
 (0)