Skip to content

Commit 8b75bb2

Browse files
committed
C#: The model generator should consider System.Type and System.DateTime as sanitizers.
1 parent 02f9aec commit 8b75bb2

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

csharp/ql/src/utils/modelgenerator/internal/CaptureModelsSpecific.qll

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,8 @@ private predicate irrelevantCollectionType(CS::Type ct) {
168168
predicate isRelevantType(CS::Type t) {
169169
not t instanceof CS::SimpleType and
170170
not t instanceof CS::Enum and
171+
not t instanceof SystemDateTimeStruct and
172+
not t instanceof SystemTypeClass and
171173
not irrelevantCollectionType(t)
172174
}
173175

csharp/ql/test/utils/modelgenerator/dataflow/Summaries.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -431,13 +431,13 @@ public Int32 M4(Int32 i)
431431
return i;
432432
}
433433

434-
// SPURIOUS-summary=Models;SimpleTypes;false;M5;(System.DateTime);;Argument[0];ReturnValue;taint;df-generated
434+
// neutral=Models;SimpleTypes;M5;(System.DateTime);summary;df-generated
435435
public DateTime M5(DateTime d)
436436
{
437437
return d;
438438
}
439439

440-
// SPURIOUS-summary=Models;SimpleTypes;false;M6;(System.Type);;Argument[0];ReturnValue;taint;df-generated
440+
// neutral=Models;SimpleTypes;M6;(System.Type);summary;df-generated
441441
public Type M6(Type t)
442442
{
443443
return t;

0 commit comments

Comments
 (0)