Skip to content

Commit 8f682ef

Browse files
committed
C++: Improve quality of some qhelp references.
1 parent e22159a commit 8f682ef

File tree

3 files changed

+5
-11
lines changed

3 files changed

+5
-11
lines changed

cpp/ql/src/Likely Bugs/Format/TooManyFormatArguments.qhelp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,8 @@ function.
2222
</example>
2323
<references>
2424

25-
<li>cplusplus.com: <a href="http://www.tutorialspoint.com/cplusplus/cpp_functions.htm">C++ Functions</a>.</li>
25+
<li>CERT C Coding Standard: <a href="https://wiki.sei.cmu.edu/confluence/display/c/FIO47-C.+Use+valid+format+strings">FIO47-C. Use valid format strings</a>.</li>
2626
<li>Microsoft C Runtime Library Reference: <a href="https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/printf-printf-l-wprintf-wprintf-l">printf, wprintf</a>.</li>
2727

28-
29-
3028
</references>
3129
</qhelp>

cpp/ql/src/Likely Bugs/Format/WrongNumberOfFormatArguments.qhelp

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ contents.
1919

2020
</overview>
2121
<recommendation>
22-
<p>Review the format and arguments expected by the highlighted function calls. Update either
23-
the format or the arguments so that the expected number of arguments are passed to the
22+
<p>Review the format and arguments expected by the highlighted function calls. Update either
23+
the format or the arguments so that the expected number of arguments are passed to the
2424
function.
2525
</p>
2626

@@ -30,11 +30,8 @@ function.
3030
</example>
3131
<references>
3232

33-
<li>CERT C Coding
34-
Standard: <a href="https://www.securecoding.cert.org/confluence/display/c/FIO30-C.+Exclude+user+input+from+format+strings">FIO30-C. Exclude user input from format strings</a>.</li>
35-
<li>cplusplus.com: <a href="http://www.tutorialspoint.com/cplusplus/cpp_functions.htm">C++ Functions</a>.</li>
33+
<li>CERT C Coding Standard: <a href="https://wiki.sei.cmu.edu/confluence/display/c/FIO47-C.+Use+valid+format+strings">FIO47-C. Use valid format strings</a>.</li>
3634
<li>Microsoft C Runtime Library Reference: <a href="https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/printf-printf-l-wprintf-wprintf-l">printf, wprintf</a>.</li>
3735

38-
3936
</references>
4037
</qhelp>

cpp/ql/src/Likely Bugs/Format/WrongTypeFormatArguments.qhelp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@ the function.
3030

3131
<li>Microsoft Learn: <a href="https://learn.microsoft.com/en-us/cpp/c-runtime-library/format-specification-syntax-printf-and-wprintf-functions?view=msvc-170">Format specification syntax: printf and wprintf functions</a>.</li>
3232
<li>cplusplus.com:<a href="https://cplusplus.com/reference/cstdio/printf/"></a>printf</li>
33-
<li>CERT C Coding"
34-
Standard: <a href="https://wiki.sei.cmu.edu/confluence/display/c/FIO47-C.+Use+valid+format+strings">FIO47-C. Use valid format strings</a>.</li>
33+
<li>CERT C Coding Standard: <a href="https://wiki.sei.cmu.edu/confluence/display/c/FIO47-C.+Use+valid+format+strings">FIO47-C. Use valid format strings</a>.</li>
3534

3635
</references>
3736
</qhelp>

0 commit comments

Comments
 (0)