Skip to content

Commit 9130603

Browse files
Address reviews - use SimpleTypeSanitizer and alter qldoc style
1 parent 460ffc8 commit 9130603

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

java/ql/lib/semmle/code/java/frameworks/android/Layout.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ private class FindViewMethod extends Method {
5050
}
5151
}
5252

53-
/** Gets a use of the view that has the given id. (i.e. from a call to a method like `findViewById`) */
53+
/** Gets a use of the view that has the given id. (that is, from a call to a method like `findViewById`) */
5454
MethodCall getAUseOfViewWithId(string id) {
5555
exists(string name, NestedClass r_id, Field id_field |
5656
id = ["@+id/", "@id/"] + name and

java/ql/lib/semmle/code/java/security/SensitiveUiQuery.qll

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ private import semmle.code.java.dataflow.ExternalFlow
55
private import semmle.code.java.dataflow.TaintTracking
66
private import semmle.code.java.security.SensitiveActions
77
private import semmle.code.java.frameworks.android.Layout
8+
private import semmle.code.java.security.Sanitizers
89

910
/** A configuration for tracking sensitive information to system notifications. */
1011
private module NotificationTrackingConfig implements DataFlow::ConfigSig {
@@ -63,9 +64,7 @@ private module TextFieldTrackingConfig implements DataFlow::ConfigSig {
6364
)
6465
}
6566

66-
predicate isBarrier(DataFlow::Node node) {
67-
node.getType() instanceof PrimitiveType or node.getType() instanceof BoxedType
68-
}
67+
predicate isBarrier(DataFlow::Node node) { node instanceof SimpleTypeSanitizer }
6968

7069
predicate isBarrierIn(DataFlow::Node node) { isSource(node) }
7170
}

0 commit comments

Comments
 (0)