Skip to content

Commit 97f9a88

Browse files
committed
fix: address PR comments
1 parent 0f63f0d commit 97f9a88

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

java/ql/lib/semmle/code/java/security/BrokenCryptoAlgorithmQuery.qll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ private class ShortStringLiteral extends StringLiteral {
1515
class BrokenAlgoLiteral extends ShortStringLiteral {
1616
BrokenAlgoLiteral() {
1717
this.getValue().regexpMatch(getInsecureAlgorithmRegex()) and
18-
not this.getValue().regexpMatch(getASecureAlgorithmName()) and
18+
// Exclude RSA/ECB/.* ciphers.
19+
not this.getValue().regexpMatch("RSA/ECB.*") and
1920
// Exclude German and French sentences.
2021
not this.getValue().regexpMatch(".*\\p{IsLowercase} des \\p{IsLetter}.*")
2122
}

0 commit comments

Comments
 (0)