Fix test expectations

owen-mc · owen-mc · commit 9aa0c9f1f32d · 2024-06-14T15:55:30.000+01:00
diff --git a/java/ql/test/query-tests/security/CWE-807/semmle/tests/ConditionalBypassTest.java b/java/ql/test/query-tests/security/CWE-807/semmle/tests/ConditionalBypassTest.java
@@ -53,10 +53,10 @@ public static void main(HttpServletRequest request) throws Exception {
 		InetAddress loopback = InetAddress.getLoopbackAddress();
 		// GOOD: reverse DNS on loopback address is fine
 		if (loopback.getCanonicalHostName().equals("localhost")) {
-			login(user, password); // $ hasConditionalBypassTest
+			login(user, password);
 		}
 		if (Inet4Address.getLoopbackAddress().getCanonicalHostName().equals("localhost")) {
-			login(user, password); // $ hasConditionalBypassTest
+			login(user, password);
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -53,10 +53,10 @@ public static void main(HttpServletRequest request) throws Exception {`
`53`	`53`	`InetAddress loopback = InetAddress.getLoopbackAddress();`
`54`	`54`	`// GOOD: reverse DNS on loopback address is fine`
`55`	`55`	`if (loopback.getCanonicalHostName().equals("localhost")) {`
`56`		`- login(user, password); // $ hasConditionalBypassTest`
	`56`	`+ login(user, password);`
`57`	`57`	`}`
`58`	`58`	`if (Inet4Address.getLoopbackAddress().getCanonicalHostName().equals("localhost")) {`
`59`		`- login(user, password); // $ hasConditionalBypassTest`
	`59`	`+ login(user, password);`
`60`	`60`	`}`
`61`	`61`	`}`
`62`	`62`