Skip to content

Commit 9db334d

Browse files
committed
update select statement, update test cases
1 parent 8258e37 commit 9db334d

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

javascript/ql/src/experimental/Security/CWE-094-dataURL/CodeInjection.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,5 +85,5 @@ class Configuration extends TaintTracking::Configuration {
8585

8686
from Configuration cfg, DataFlow::PathNode source, DataFlow::PathNode sink
8787
where cfg.hasFlowPath(source, sink)
88-
select sink.getNode(), source, sink, sink.getNode() + "This command line depends on a $@.",
88+
select sink.getNode(), source, sink, "This command line depends on a $@.",
8989
source.getNode(), "user-provided value"

javascript/ql/test/experimental/Security/CWE-094-dataURL/CodeInjection.expected

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
WARNING: Unused class Sink (/home/am/CodeQL-home/codeql-repo-amammad/javascript/ql/src/experimental/Security/CWE-094-dataURL/CodeInjection.ql:23,16-20)
21
nodes
32
| test.js:5:11:5:44 | payload |
43
| test.js:5:21:5:44 | req.que ... rameter |
@@ -46,7 +45,7 @@ edges
4645
| test.js:19:18:19:24 | payload | test.js:19:18:19:30 | payload + sth |
4746
| test.js:19:18:19:24 | payload | test.js:19:18:19:30 | payload + sth |
4847
#select
49-
| test.js:7:16:7:25 | payloadURL | test.js:5:21:5:44 | req.que ... rameter | test.js:7:16:7:25 | payloadURL | payloadURL depends on a $@. | test.js:5:21:5:44 | req.que ... rameter | user-provided value |
50-
| test.js:10:16:10:25 | payloadURL | test.js:5:21:5:44 | req.que ... rameter | test.js:10:16:10:25 | payloadURL | payloadURL depends on a $@. | test.js:5:21:5:44 | req.que ... rameter | user-provided value |
51-
| test.js:18:18:18:24 | payload | test.js:17:21:17:44 | req.que ... rameter | test.js:18:18:18:24 | payload | payload depends on a $@. | test.js:17:21:17:44 | req.que ... rameter | user-provided value |
52-
| test.js:19:18:19:30 | payload + sth | test.js:17:21:17:44 | req.que ... rameter | test.js:19:18:19:30 | payload + sth | payload + sth depends on a $@. | test.js:17:21:17:44 | req.que ... rameter | user-provided value |
48+
| test.js:7:16:7:25 | payloadURL | test.js:5:21:5:44 | req.que ... rameter | test.js:7:16:7:25 | payloadURL | This command line depends on a $@. | test.js:5:21:5:44 | req.que ... rameter | user-provided value |
49+
| test.js:10:16:10:25 | payloadURL | test.js:5:21:5:44 | req.que ... rameter | test.js:10:16:10:25 | payloadURL | This command line depends on a $@. | test.js:5:21:5:44 | req.que ... rameter | user-provided value |
50+
| test.js:18:18:18:24 | payload | test.js:17:21:17:44 | req.que ... rameter | test.js:18:18:18:24 | payload | This command line depends on a $@. | test.js:17:21:17:44 | req.que ... rameter | user-provided value |
51+
| test.js:19:18:19:30 | payload + sth | test.js:17:21:17:44 | req.que ... rameter | test.js:19:18:19:30 | payload + sth | This command line depends on a $@. | test.js:17:21:17:44 | req.que ... rameter | user-provided value |

0 commit comments

Comments
 (0)