Skip to content

Commit 9ed6da1

Browse files
committed
JS: prepare to extend Array tests
Oh how I have enjoyed working with InlineExpectationTests for these sort of things, not worrying about all the .expected files changing because you add a few lines in the middle of your tests :D
1 parent 1027ca2 commit 9ed6da1

File tree

4 files changed

+824
-819
lines changed

4 files changed

+824
-819
lines changed

javascript/ql/test/library-tests/Arrays/DataFlow.expected

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,20 +3,20 @@
33
| arrays.js:2:16:2:23 | "source" | arrays.js:15:27:15:27 | e |
44
| arrays.js:2:16:2:23 | "source" | arrays.js:16:23:16:23 | e |
55
| arrays.js:2:16:2:23 | "source" | arrays.js:20:8:20:16 | arr.pop() |
6-
| arrays.js:2:16:2:23 | "source" | arrays.js:52:10:52:10 | x |
7-
| arrays.js:2:16:2:23 | "source" | arrays.js:56:10:56:10 | x |
8-
| arrays.js:2:16:2:23 | "source" | arrays.js:60:10:60:10 | x |
9-
| arrays.js:2:16:2:23 | "source" | arrays.js:66:10:66:10 | x |
6+
| arrays.js:2:16:2:23 | "source" | arrays.js:57:10:57:10 | x |
7+
| arrays.js:2:16:2:23 | "source" | arrays.js:61:10:61:10 | x |
8+
| arrays.js:2:16:2:23 | "source" | arrays.js:65:10:65:10 | x |
109
| arrays.js:2:16:2:23 | "source" | arrays.js:71:10:71:10 | x |
11-
| arrays.js:2:16:2:23 | "source" | arrays.js:74:8:74:29 | arr.fin ... llback) |
12-
| arrays.js:2:16:2:23 | "source" | arrays.js:77:8:77:35 | arrayFi ... llback) |
13-
| arrays.js:2:16:2:23 | "source" | arrays.js:81:10:81:10 | x |
14-
| arrays.js:2:16:2:23 | "source" | arrays.js:84:8:84:17 | arr.at(-1) |
10+
| arrays.js:2:16:2:23 | "source" | arrays.js:76:10:76:10 | x |
11+
| arrays.js:2:16:2:23 | "source" | arrays.js:79:8:79:29 | arr.fin ... llback) |
12+
| arrays.js:2:16:2:23 | "source" | arrays.js:82:8:82:35 | arrayFi ... llback) |
13+
| arrays.js:2:16:2:23 | "source" | arrays.js:86:10:86:10 | x |
14+
| arrays.js:2:16:2:23 | "source" | arrays.js:89:8:89:17 | arr.at(-1) |
1515
| arrays.js:18:22:18:29 | "source" | arrays.js:18:50:18:50 | e |
1616
| arrays.js:22:15:22:22 | "source" | arrays.js:23:8:23:17 | arr2.pop() |
1717
| arrays.js:25:15:25:22 | "source" | arrays.js:26:8:26:17 | arr3.pop() |
1818
| arrays.js:29:21:29:28 | "source" | arrays.js:30:8:30:17 | arr4.pop() |
19-
| arrays.js:29:21:29:28 | "source" | arrays.js:33:8:33:17 | arr5.pop() |
20-
| arrays.js:29:21:29:28 | "source" | arrays.js:35:8:35:26 | arr5.slice(2).pop() |
21-
| arrays.js:29:21:29:28 | "source" | arrays.js:41:8:41:17 | arr6.pop() |
22-
| arrays.js:44:4:44:11 | "source" | arrays.js:45:10:45:18 | ary.pop() |
19+
| arrays.js:29:21:29:28 | "source" | arrays.js:38:8:38:17 | arr5.pop() |
20+
| arrays.js:29:21:29:28 | "source" | arrays.js:40:8:40:26 | arr5.slice(2).pop() |
21+
| arrays.js:29:21:29:28 | "source" | arrays.js:46:8:46:17 | arr6.pop() |
22+
| arrays.js:49:4:49:11 | "source" | arrays.js:50:10:50:18 | ary.pop() |

javascript/ql/test/library-tests/Arrays/TaintFlow.expected

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3,24 +3,24 @@
33
| arrays.js:2:16:2:23 | "source" | arrays.js:15:27:15:27 | e |
44
| arrays.js:2:16:2:23 | "source" | arrays.js:16:23:16:23 | e |
55
| arrays.js:2:16:2:23 | "source" | arrays.js:20:8:20:16 | arr.pop() |
6-
| arrays.js:2:16:2:23 | "source" | arrays.js:49:8:49:13 | arr[0] |
7-
| arrays.js:2:16:2:23 | "source" | arrays.js:52:10:52:10 | x |
8-
| arrays.js:2:16:2:23 | "source" | arrays.js:56:10:56:10 | x |
9-
| arrays.js:2:16:2:23 | "source" | arrays.js:60:10:60:10 | x |
10-
| arrays.js:2:16:2:23 | "source" | arrays.js:66:10:66:10 | x |
6+
| arrays.js:2:16:2:23 | "source" | arrays.js:54:8:54:13 | arr[0] |
7+
| arrays.js:2:16:2:23 | "source" | arrays.js:57:10:57:10 | x |
8+
| arrays.js:2:16:2:23 | "source" | arrays.js:61:10:61:10 | x |
9+
| arrays.js:2:16:2:23 | "source" | arrays.js:65:10:65:10 | x |
1110
| arrays.js:2:16:2:23 | "source" | arrays.js:71:10:71:10 | x |
12-
| arrays.js:2:16:2:23 | "source" | arrays.js:74:8:74:29 | arr.fin ... llback) |
13-
| arrays.js:2:16:2:23 | "source" | arrays.js:77:8:77:35 | arrayFi ... llback) |
14-
| arrays.js:2:16:2:23 | "source" | arrays.js:81:10:81:10 | x |
15-
| arrays.js:2:16:2:23 | "source" | arrays.js:84:8:84:17 | arr.at(-1) |
11+
| arrays.js:2:16:2:23 | "source" | arrays.js:76:10:76:10 | x |
12+
| arrays.js:2:16:2:23 | "source" | arrays.js:79:8:79:29 | arr.fin ... llback) |
13+
| arrays.js:2:16:2:23 | "source" | arrays.js:82:8:82:35 | arrayFi ... llback) |
14+
| arrays.js:2:16:2:23 | "source" | arrays.js:86:10:86:10 | x |
15+
| arrays.js:2:16:2:23 | "source" | arrays.js:89:8:89:17 | arr.at(-1) |
1616
| arrays.js:18:22:18:29 | "source" | arrays.js:18:50:18:50 | e |
1717
| arrays.js:22:15:22:22 | "source" | arrays.js:23:8:23:17 | arr2.pop() |
1818
| arrays.js:25:15:25:22 | "source" | arrays.js:26:8:26:17 | arr3.pop() |
1919
| arrays.js:29:21:29:28 | "source" | arrays.js:30:8:30:17 | arr4.pop() |
20-
| arrays.js:29:21:29:28 | "source" | arrays.js:33:8:33:17 | arr5.pop() |
21-
| arrays.js:29:21:29:28 | "source" | arrays.js:35:8:35:26 | arr5.slice(2).pop() |
22-
| arrays.js:29:21:29:28 | "source" | arrays.js:41:8:41:17 | arr6.pop() |
23-
| arrays.js:44:4:44:11 | "source" | arrays.js:45:10:45:18 | ary.pop() |
24-
| arrays.js:44:4:44:11 | "source" | arrays.js:46:10:46:12 | ary |
25-
| arrays.js:86:9:86:16 | "source" | arrays.js:86:8:86:34 | ["sourc ... ) => x) |
26-
| arrays.js:87:9:87:16 | "source" | arrays.js:87:8:87:36 | ["sourc ... => !!x) |
20+
| arrays.js:29:21:29:28 | "source" | arrays.js:38:8:38:17 | arr5.pop() |
21+
| arrays.js:29:21:29:28 | "source" | arrays.js:40:8:40:26 | arr5.slice(2).pop() |
22+
| arrays.js:29:21:29:28 | "source" | arrays.js:46:8:46:17 | arr6.pop() |
23+
| arrays.js:49:4:49:11 | "source" | arrays.js:50:10:50:18 | ary.pop() |
24+
| arrays.js:49:4:49:11 | "source" | arrays.js:51:10:51:12 | ary |
25+
| arrays.js:91:9:91:16 | "source" | arrays.js:91:8:91:34 | ["sourc ... ) => x) |
26+
| arrays.js:92:9:92:16 | "source" | arrays.js:92:8:92:36 | ["sourc ... => !!x) |

javascript/ql/test/library-tests/Arrays/arrays.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,11 @@
2929
arr4.splice(0, 0, "source");
3030
sink(arr4.pop()); // NOT OK
3131

32+
// var arr4_variant = [];
33+
// arr4_variant.splice(0, 0, "safe", "source");
34+
// arr4_variant.pop();
35+
// sink(arr4_variant.pop()); // NOT OK
36+
3237
var arr5 = [].concat(arr4);
3338
sink(arr5.pop()); // NOT OK
3439

0 commit comments

Comments
 (0)