Skip to content

Commit a4df20d

Browse files
owen-mcowen-mc
committed
Rename UntrustedFlowSource to RemoteFlowSource
Relaxed match case requirement. Again skipped one instance in an old change note.
1 parent 81eaa6e commit a4df20d

File tree

7 files changed

+48
-48
lines changed

7 files changed

+48
-48
lines changed

‎go/ql/test/experimental/frameworks/CleverGo/TaintTracking.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎go/ql/test/experimental/frameworks/CleverGo/UntrustedSources.go

Lines changed: 16 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎go/ql/test/experimental/frameworks/CleverGo/UntrustedSources.ql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ import TestUtilities.InlineExpectationsTest
33
import experimental.frameworks.CleverGo
44

55
module RemoteFlowSourceTest implements TestSig {
6-
string getARelevantTag() { result = "untrustedFlowSource" }
6+
string getARelevantTag() { result = "remoteFlowSource" }
77

88
predicate hasActualResult(Location location, string element, string tag, string value) {
9-
tag = "untrustedFlowSource" and
9+
tag = "remoteFlowSource" and
1010
exists(DataFlow::CallNode sinkCall, DataFlow::ArgumentNode arg |
1111
sinkCall.getCalleeName() = "sink" and
1212
arg = sinkCall.getAnArgument() and

‎go/ql/test/experimental/frameworks/Fiber/UntrustedFlowSources.go

Lines changed: 23 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎go/ql/test/experimental/frameworks/Fiber/UntrustedFlowSources.ql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ import TestUtilities.InlineExpectationsTest
33
import experimental.frameworks.Fiber
44

55
module RemoteFlowSourceTest implements TestSig {
6-
string getARelevantTag() { result = "untrustedFlowSource" }
6+
string getARelevantTag() { result = "remoteFlowSource" }
77

88
predicate hasActualResult(Location location, string element, string tag, string value) {
9-
tag = "untrustedFlowSource" and
9+
tag = "remoteFlowSource" and
1010
exists(DataFlow::CallNode sinkCall, DataFlow::ArgumentNode arg |
1111
sinkCall.getCalleeName() = "sink" and
1212
arg = sinkCall.getAnArgument() and

‎go/ql/test/library-tests/semmle/go/frameworks/ElazarlGoproxy/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import (
1111
)
1212

1313
func handler(r *http.Request, ctx *goproxy.ProxyCtx) (*http.Request, *http.Response) {
14-
data := ctx.UserData // $ untrustedflowsource="selection of UserData"
14+
data := ctx.UserData // $ remoteflowsource="selection of UserData"
1515

1616
// note no content type result here because we don't seem to extract the value of `ContentTypeHtml`
1717
return r, goproxy.NewResponse(r, goproxy.ContentTypeHtml, http.StatusForbidden, fmt.Sprintf("<body>Bad request: %v</body>", data)) // $ headerwrite=status:403

‎go/ql/test/library-tests/semmle/go/frameworks/ElazarlGoproxy/test.ql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ import go
22
import TestUtilities.InlineExpectationsTest
33

44
module RemoteFlowSourceTest implements TestSig {
5-
string getARelevantTag() { result = "untrustedflowsource" }
5+
string getARelevantTag() { result = "remoteflowsource" }
66

77
predicate hasActualResult(Location location, string element, string tag, string value) {
8-
tag = "untrustedflowsource" and
8+
tag = "remoteflowsource" and
99
value = element and
1010
exists(RemoteFlowSource src | value = "\"" + src.toString() + "\"" |
1111
src.hasLocationInfo(location.getFile().getAbsolutePath(), location.getStartLine(),

0 commit comments

Comments
 (0)