Skip to content

Commit ac4601c

Browse files
asgerfRasmusWL
andauthored
Update javascript/ql/lib/semmle/javascript/dataflow/internal/CallGraphs.qll
Co-authored-by: Rasmus Wriedt Larsen <[email protected]>
1 parent 81b0486 commit ac4601c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

javascript/ql/lib/semmle/javascript/dataflow/internal/CallGraphs.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ module CallGraph {
250250
result = node.(DataFlow::ObjectLiteralNode).getPropertySetter(_)
251251
) and
252252
not node.getTopLevel().isExterns() and
253-
// Do not track instance methods on classes
253+
// Ignore writes to `this` inside a constructor, since this is already handled by instance method tracking
254254
not exists(DataFlow::ClassNode cls |
255255
node = cls.getConstructor().getReceiver()
256256
or

0 commit comments

Comments
 (0)