Skip to content

Commit c16a282

Browse files
committed
fix format warnings/errors
1 parent 307187f commit c16a282

File tree

6 files changed

+8
-12
lines changed

6 files changed

+8
-12
lines changed

javascript/ql/src/experimental/Security/CWE-522-DecompressionBombs/Bombs_jszip.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* @problem.severity error
66
* @security-severity 7.8
77
* @precision medium
8-
* @id js/user-controlled-file-decompression
8+
* @id js/user-controlled-file-decompression-jszip
99
* @tags security
1010
* experimental
1111
* external/cwe/cwe-409

javascript/ql/src/experimental/Security/CWE-522-DecompressionBombs/Bombs_node-tar.ql

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,12 @@
55
* @problem.severity error
66
* @security-severity 7.8
77
* @precision medium
8-
* @id js/user-controlled-file-decompression
8+
* @id js/user-controlled-file-decompression--tar
99
* @tags security
1010
* experimental
1111
* external/cwe/cwe-409
1212
*/
1313

14-
import javascript
1514
import DataFlow::PathGraph
1615
import API
1716
import semmle.javascript.Concepts

javascript/ql/src/experimental/Security/CWE-522-DecompressionBombs/Bombs_zlib-Pako-AdmZip.ql

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* @problem.severity error
66
* @security-severity 7.8
77
* @precision medium
8-
* @id js/user-controlled-file-decompression
8+
* @id js/user-controlled-file-decompression-Zlib-Pako-AdmZip
99
* @tags security
1010
* experimental
1111
* external/cwe/cwe-409
@@ -65,11 +65,7 @@ class BombConfiguration extends TaintTracking::Configuration {
6565
)
6666
or
6767
sink =
68-
[
69-
DataFlow::moduleMember("pako", ["inflate", "inflateRaw", "ungzip"])
70-
.getACall()
71-
.getArgument(0)
72-
]
68+
DataFlow::moduleMember("pako", ["inflate", "inflateRaw", "ungzip"]).getACall().getArgument(0)
7369
or
7470
exists(API::Node n | n = API::moduleImport("adm-zip").getInstance() |
7571
(
@@ -85,7 +81,7 @@ class BombConfiguration extends TaintTracking::Configuration {
8581
readablePipeAdditionalTaintStep(pred, succ)
8682
or
8783
// succ = new Uint8Array(pred)
88-
exists(DataFlow::Node n, NewExpr ne | ne = n.asExpr().(NewExpr) |
84+
exists(DataFlow::Node n, NewExpr ne | ne = n.asExpr() |
8985
pred.asExpr() = ne.getArgument(0) and
9086
succ.asExpr() = ne and
9187
ne.getCalleeName() = "Uint8Array"

javascript/ql/src/experimental/Security/CWE-522-DecompressionBombs/CommandLineSource.qll

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import DataFlow::PathGraph
33
import API
44

55
/**
6+
* A Command Line argument as a Flow Source
67
* there are FP when the types are not str
78
* because int,boolean types are not really dangerous as a source node
89
*/

javascript/ql/src/experimental/Security/CWE-522-DecompressionBombs/SequelizeModelMethodCall.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
import javascript
1212
import DataFlow::PathGraph
13-
import sequelizeModelTypes::sequelizeModel
13+
import sequelizeModelTypes::SequelizeModel
1414
import API
1515

1616
class SequelizeModelConfiguration extends TaintTracking::Configuration {

javascript/ql/src/experimental/Security/CWE-522-DecompressionBombs/sequelizeModelTypes.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import javascript
22
import DataFlow
33

4-
module sequelizeModel {
4+
module SequelizeModel {
55
SourceNode sequelizeModelAsSourceNode(TypeTracker t) {
66
t.start() and
77
exists(

0 commit comments

Comments
 (0)