C++: Ensure 'isConditionalTemporaryDestructorCall' only holds when the reused expression is a temporary.

MathiasVP · MathiasVP · commit c325a79206db · 2024-04-09T09:32:54.000+01:00
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedElement.qll b/cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedElement.qll
@@ -287,7 +287,10 @@ private predicate isInConditionalEvaluation(Expr e) {
 }
 
 private predicate isConditionalTemporaryDestructorCall(DestructorCall dc) {
-  isInConditionalEvaluation(dc.getQualifier().(ReuseExpr).getReusedExpr())
+  exists(TemporaryObjectExpr temp |
+    temp = dc.getQualifier().(ReuseExpr).getReusedExpr() and
+    isInConditionalEvaluation(temp)
+  )
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -287,7 +287,10 @@ private predicate isInConditionalEvaluation(Expr e) {`
`287`	`287`	`}`
`288`	`288`
`289`	`289`	`private predicate isConditionalTemporaryDestructorCall(DestructorCall dc) {`
`290`		`- isInConditionalEvaluation(dc.getQualifier().(ReuseExpr).getReusedExpr())`
	`290`	`+ exists(TemporaryObjectExpr temp \|`
	`291`	`+ temp = dc.getQualifier().(ReuseExpr).getReusedExpr() and`
	`292`	`+ isInConditionalEvaluation(temp)`
	`293`	`+ )`
`291`	`294`	`}`
`292`	`295`
`293`	`296`	`/**`