Skip to content

Commit c4a0f36

Browse files
committed
JS: Fix handling of unknown properties
These would shorten the expected distance to a node, but would never be usable as an edge, meaning we failed to pick a preferred predecessor.
1 parent 3ff9506 commit c4a0f36

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

javascript/ql/lib/semmle/javascript/endpoints/EndpointNaming.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ private string join(string x, string y) {
3939
private predicate isPackageExport(API::Node node) { node = API::moduleExport(_) }
4040

4141
private predicate relevantEdge(API::Node pred, API::Node succ) {
42-
succ = pred.getAMember() and
42+
succ = pred.getMember(_) and
4343
not isPrivateLike(succ)
4444
}
4545

javascript/ql/test/library-tests/EndpointNaming/EndpointNaming.expected

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ testFailures
22
| pack11/index.ts:33:1:33:16 | | Unexpected result: method=(pack11).C3.privateField |
33
| pack11/index.ts:33:18:33:69 | // $ me ... ng.name | Missing result:method=(pack11).C3.publicField.really.long.name |
44
| pack11/index.ts:41:23:41:24 | | Unexpected result: alias=(pack11).C3.publicField.really.long.name==(pack11).C3.privateField |
5-
| pack11/index.ts:49:12:49:53 | // $ me ... .name.m | Missing result:method=(pack11).C4.really.long.name.m |
65
ambiguousPreferredPredecessor
76
| pack2/lib.js:8:22:8:34 | def moduleImport("pack2").getMember("exports").getMember("lib").getMember("LibClass").getMember("foo") |
87
ambiguousSinkName

0 commit comments

Comments
 (0)