Skip to content

Commit caa4505

Browse files
committed
Dataflow: Improve join-order.
Join with the functional getApprox before filtering with revFlow as this is always better.
1 parent 55e6255 commit caa4505

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3986,8 +3986,8 @@ module MakeImpl<InputSig Lang> {
39863986
AccessPath ap
39873987
) {
39883988
exists(DataFlowType t0 |
3989-
pathStep0(mid, node, state, cc, sc, t0, ap) and
3990-
Stage5::revFlow(node, state, ap.getApprox()) and
3989+
pathStep0(mid, pragma[only_bind_into](node), pragma[only_bind_into](state), cc, sc, t0, ap) and
3990+
Stage5::revFlow(pragma[only_bind_into](node), pragma[only_bind_into](state), ap.getApprox()) and
39913991
strengthenType(node, t0, t) and
39923992
not inBarrier(node, state)
39933993
)

0 commit comments

Comments
 (0)