Trivial: improve parameter names

owen-mc · owen-mc · commit cf997fddf62f · 2024-05-23T11:04:09.000+01:00
These names make more sense and match everywhere
else that this function signature is used.
diff --git a/go/ql/lib/semmle/go/dataflow/internal/TaintTrackingUtil.qll b/go/ql/lib/semmle/go/dataflow/internal/TaintTrackingUtil.qll
@@ -214,11 +214,11 @@ abstract class FunctionModel extends Function {
 }
 
 /**
- * Holds if the additional step from `src` to `sink` should be included in all
+ * Holds if the additional step from `node1` to `node2` should be included in all
  * global taint flow configurations.
  */
-predicate defaultAdditionalTaintStep(DataFlow::Node src, DataFlow::Node sink, string model) {
-  localAdditionalTaintStep(src, sink, model)
+predicate defaultAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2, string model) {
+  localAdditionalTaintStep(node1, node2, model)
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -214,11 +214,11 @@ abstract class FunctionModel extends Function {`
`214`	`214`	`}`
`215`	`215`
`216`	`216`	`/**`
`217`		- * Holds if the additional step from `src` to `sink` should be included in all
	`217`	+ * Holds if the additional step from `node1` to `node2` should be included in all
`218`	`218`	`* global taint flow configurations.`
`219`	`219`	`*/`
`220`		`-predicate defaultAdditionalTaintStep(DataFlow::Node src, DataFlow::Node sink, string model) {`
`221`		`- localAdditionalTaintStep(src, sink, model)`
	`220`	`+predicate defaultAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2, string model) {`
	`221`	`+ localAdditionalTaintStep(node1, node2, model)`
`222`	`222`	`}`
`223`	`223`
`224`	`224`	`/**`