Swift: Remove now redundant additional taint step. from the XXE query.

geoffw0 · geoffw0 · commit da14f428e225 · 2023-10-13T13:57:54.000+01:00
diff --git a/swift/ql/lib/codeql/swift/security/XXEExtensions.qll b/swift/ql/lib/codeql/swift/security/XXEExtensions.qll
@@ -188,13 +188,6 @@ private predicate lib2xmlOptionLocalTaintStep(DataFlow::Node source, DataFlow::N
   exists(MemberRefExpr rawValue | rawValue.getMember().(VarDecl).getName() = "rawValue" |
     source.asExpr() = rawValue.getBase() and sink.asExpr() = rawValue
   )
-  or
-  exists(ApplyExpr int32Init |
-    int32Init.getStaticTarget().(Initializer).getEnclosingDecl().asNominalTypeDecl().getName() =
-      "SignedInteger"
-  |
-    source.asExpr() = int32Init.getAnArgument().getExpr() and sink.asExpr() = int32Init
-  )
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -188,13 +188,6 @@ private predicate lib2xmlOptionLocalTaintStep(DataFlow::Node source, DataFlow::N`
`188`	`188`	`exists(MemberRefExpr rawValue \| rawValue.getMember().(VarDecl).getName() = "rawValue" \|`
`189`	`189`	`source.asExpr() = rawValue.getBase() and sink.asExpr() = rawValue`
`190`	`190`	`)`
`191`		`- or`
`192`		`- exists(ApplyExpr int32Init \|`
`193`		`- int32Init.getStaticTarget().(Initializer).getEnclosingDecl().asNominalTypeDecl().getName() =`
`194`		`- "SignedInteger"`
`195`		`- \|`
`196`		`- source.asExpr() = int32Init.getAnArgument().getExpr() and sink.asExpr() = int32Init`
`197`		`- )`
`198`	`191`	`}`
`199`	`192`
`200`	`193`	`/**`