Skip to content

Commit e81a4fc

Browse files
committed
remove CLI sources Library file and local sources for lower FPs
1 parent 77dcd68 commit e81a4fc

File tree

4 files changed

+2
-208
lines changed

4 files changed

+2
-208
lines changed

javascript/ql/src/experimental/Security/CWE-522-DecompressionBombs/CommandLineSource.qll

Lines changed: 0 additions & 105 deletions
This file was deleted.

javascript/ql/src/experimental/Security/CWE-522-DecompressionBombs/DecompressionBombs.ql

Lines changed: 2 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -12,39 +12,13 @@
1212
*/
1313

1414
import javascript
15-
import CommandLineSource
1615
import ReadableAdditionalStep
16+
import DataFlow::PathGraph
1717

1818
class BombConfiguration extends TaintTracking::Configuration {
1919
BombConfiguration() { this = "DecompressionBombs" }
2020

21-
override predicate isSource(DataFlow::Node source) {
22-
exists(Function f | source.asExpr() = f.getAParameter() |
23-
not exists(source.getALocalSource().getStringValue())
24-
)
25-
or
26-
source instanceof RemoteFlowSource
27-
or
28-
source.asExpr() = any(Parameter cls)
29-
or
30-
exists(FileSystemReadAccess fsra | source = fsra.getADataNode() |
31-
not exists(fsra.getALocalSource().getStringValue())
32-
)
33-
or
34-
exists(API::Node node |
35-
source = node.getParameter(0).asSink() and
36-
node = API::moduleImport("adm-zip") and
37-
not exists(source.getALocalSource().getStringValue())
38-
)
39-
or
40-
source =
41-
API::moduleImport("tar")
42-
.getMember(["x", "extract"])
43-
.getParameter(0)
44-
.getMember("file")
45-
.asSink() and
46-
not source.getALocalSource().mayHaveStringValue(_)
47-
}
21+
override predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
4822

4923
override predicate isSink(DataFlow::Node sink) {
5024
// jszip

javascript/ql/src/experimental/Security/CWE-522-DecompressionBombs/SequelizeModelMethodCallDemo.ql

Lines changed: 0 additions & 53 deletions
This file was deleted.

javascript/ql/src/experimental/Security/CWE-522-DecompressionBombs/sequelizeModelTypes.qll

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)