Skip to content

Commit eaba798

Browse files
Apply suggestions from code review
Co-authored-by: yoff <[email protected]>
1 parent 5d94658 commit eaba798

File tree

1 file changed

+8
-19
lines changed

1 file changed

+8
-19
lines changed

python/ql/lib/semmle/python/frameworks/Gradio.qll

Lines changed: 8 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ module Gradio {
3333
.getMember([
3434
"change", "input", "click", "submit", "edit", "clear", "play", "pause", "stop",
3535
"end", "start_recording", "pause_recording", "stop_recording", "focus", "blur",
36-
"upload", "release", "select", "stream", "like", "load", "like", "key_up",
36+
"upload", "release", "select", "stream", "like", "load", "key_up",
3737
])
3838
.getACall()
3939
}
@@ -90,11 +90,7 @@ module Gradio {
9090
or
9191
call instanceof GradioInterface
9292
) and
93-
(
94-
this = call.getKeywordParameter("fn").getParameter(_).asSource()
95-
or
96-
this = call.getParameter(0).getParameter(_).asSource()
97-
) and
93+
this = call.getParameter(0, "fn").getParameter(_).asSource() and
9894
// exclude lists of parameters given to `inputs`
9995
not call.getKeywordParameter("inputs").asSink().asCfgNode() instanceof ListNode and
10096
not call.getParameter(1).asSink().asCfgNode() instanceof ListNode
@@ -136,19 +132,12 @@ module Gradio {
136132
or
137133
node.getParameter(1).asSink().asCfgNode() instanceof ListNode
138134
) and
139-
exists(int i |
140-
(
141-
nodeTo = node.getParameter(0).getParameter(i).asSource()
142-
or
143-
nodeTo = node.getKeywordParameter("fn").getParameter(i).asSource()
144-
) and
145-
(
146-
nodeFrom.asCfgNode() =
147-
node.getKeywordParameter("inputs").asSink().asCfgNode().(ListNode).getElement(i)
148-
or
149-
nodeFrom.asCfgNode() =
150-
node.getParameter(1).asSink().asCfgNode().(ListNode).getElement(i)
151-
)
135+
exists(int i | nodeTo = node.getParameter(0, "fn").getParameter(i).asSource() |
136+
nodeFrom.asCfgNode() =
137+
node.getKeywordParameter("inputs").asSink().asCfgNode().(ListNode).getElement(i)
138+
or
139+
nodeFrom.asCfgNode() =
140+
node.getParameter(1).asSink().asCfgNode().(ListNode).getElement(i)
152141
)
153142
)
154143
)

0 commit comments

Comments
 (0)