Java/Shared: Rename 'joinStep0' to 'joinStep'.

Author: MathiasVP

java/ql/lib/semmle/code/java/dataflow/TypeFlow.qll

@@ -75,7 +75,7 @@ private module Input implements TypeFlowInput<J::Location> {
    * Holds if data can flow from `n1` to `n2` in one step, and `n1` is not
    * necessarily functionally determined by `n2`.
    */
-  predicate joinStep0(TypeFlowNode n1, TypeFlowNode n2) {
+  predicate joinStep(TypeFlowNode n1, TypeFlowNode n2) {
     n2.asExpr().(ChooseExpr).getAResultExpr() = n1.asExpr()
     or
     exists(Field f, Expr e |
@@ -134,7 +134,7 @@ private module Input implements TypeFlowInput<J::Location> {
       not exists(decl.getInit())
     )
     or
-    forex(TypeFlowNode mid | joinStep0(mid, n) | Make<J::Location, Input>::isNull(mid)) and
+    forex(TypeFlowNode mid | joinStep(mid, n) | Make<J::Location, Input>::isNull(mid)) and
     // Fields that are never assigned a non-null value are probably set by
     // reflection and are thus not always null.
     not exists(n.asField())

shared/typeflow/codeql/typeflow/TypeFlow.qll

@@ -31,7 +31,7 @@ signature module TypeFlowInput<LocationSig Location> {
    * Holds if data can flow from `n1` to `n2` in one step, and `n1` is not
    * necessarily functionally determined by `n2`.
    */
-  predicate joinStep0(TypeFlowNode n1, TypeFlowNode n2);
+  predicate joinStep(TypeFlowNode n1, TypeFlowNode n2);
 
   /**
    * Holds if data can flow from `n1` to `n2` in one step, and `n1` is

shared/typeflow/codeql/typeflow/internal/TypeFlowImpl.qll

@@ -16,7 +16,7 @@ module TypeFlow<LocationSig Location, TypeFlowInput<Location> I> {
    * Holds if data can flow from `n1` to `n2` in one step, `n1` is not necessarily
    * functionally determined by `n2`, and `n1` might take a non-null value.
    */
-  predicate joinStep(TypeFlowNode n1, TypeFlowNode n2) { joinStep0(n1, n2) and not isNull(n1) }
+  predicate joinStep(TypeFlowNode n1, TypeFlowNode n2) { I::joinStep(n1, n2) and not isNull(n1) }
 
   private predicate anyStep(TypeFlowNode n1, TypeFlowNode n2) { joinStep(n1, n2) or step(n1, n2) }