Skip to content

Commit f06c3fd

Browse files
committed
fix qhelp, fix duplicate query id
1 parent 78dc650 commit f06c3fd

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

ruby/ql/src/experimental/CWE-522-DecompressionBombs/DecompressionBombs.qhelp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@
1010
<recommendation>
1111

1212
<p>When you want to decompress a user-provided compressed file you must be careful about the decompression ratio or read these files within a loop byte by byte to be able to manage the decompressed size in each cycle of the loop.</p>
13-
14-
</recommendation>
1513
<p>Please read official RubyZip Documentation <a href="https://github.com/rubyzip/rubyzip/#size-validation">here</a></p>
14+
</recommendation>
1615
<example>
1716
<p>Rubyzip: According to <a href="https://github.com/rubyzip/rubyzip/#reading-a-zip-file">official</a> Documentation</p>
1817
<sample src="example_good.rb" />

ruby/ql/src/experimental/CWE-522-DecompressionBombs/DecompressionBombs.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* @problem.severity error
66
* @security-severity 7.8
77
* @precision high
8-
* @id rb/user-controlled-file-decompression
8+
* @id rb/user-controlled-data-decompression
99
* @tags security
1010
* experimental
1111
* external/cwe/cwe-409

0 commit comments

Comments
 (0)