Skip to content

Commit f353065

Browse files
committed
Java: Allow overloading for exact model matches.
1 parent 0f86408 commit f353065

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -417,19 +417,19 @@ private Element interpretElement0(
417417
) {
418418
elementSpec(package, type, subtypes, name, signature, _) and
419419
(
420-
exists(Member m, boolean isExact0 |
420+
exists(Member m |
421421
(
422-
result = m and isExact0 = true
422+
result = m and isExact = true
423423
or
424-
subtypes = true and result.(SrcMethod).overridesOrInstantiates+(m) and isExact0 = false
424+
subtypes = true and result.(SrcMethod).overridesOrInstantiates+(m) and isExact = false
425425
) and
426426
m.hasQualifiedName(package, type, name)
427427
|
428-
signature = "" and isExact = false
428+
signature = ""
429429
or
430-
paramsStringQualified(m) = signature and isExact = isExact0
430+
paramsStringQualified(m) = signature
431431
or
432-
paramsString(m) = signature and isExact = isExact0
432+
paramsString(m) = signature
433433
)
434434
or
435435
exists(RefType t |

shared/dataflow/codeql/dataflow/internal/FlowSummaryImpl.qll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -256,8 +256,8 @@ module Make<
256256

257257
/**
258258
* Holds if there exists a model for which this callable is an exact
259-
* match, that is, no overriding or overloading was used to identify this
260-
* callable from the model.
259+
* match, that is, no overriding was used to identify this callable from
260+
* the model.
261261
*/
262262
predicate hasExactModel() { none() }
263263
}
@@ -302,8 +302,8 @@ module Make<
302302

303303
/**
304304
* Holds if there exists a model for which this callable is an exact
305-
* match, that is, no overriding or overloading was used to identify this
306-
* callable from the model.
305+
* match, that is, no overriding was used to identify this callable from
306+
* the model.
307307
*/
308308
predicate hasExactModel() { none() }
309309
}

0 commit comments

Comments
 (0)