Skip to content

Commit f8e17fe

Browse files
committed
Accept expected test changes
1 parent 7694618 commit f8e17fe

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

go/ql/test/library-tests/semmle/go/dataflow/ExternalValueFlow/test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ func simpleflow() {
124124
slice1[0] = src.(string)
125125
slice2 := make([]string, 2)
126126
copy(slice2, slice1)
127-
b.Sink1(slice2[0]) // $ MISSING: hasValueFlow="index expression" // this is a bug, but it is normally covered because it works with taint tracking
127+
b.Sink1(slice2[0]) // $ hasValueFlow="index expression"
128128

129129
ch := make(chan string)
130130
ch <- a.Src1().(string)

go/ql/test/library-tests/semmle/go/dataflow/FlowSteps/LocalTaintStep.expected

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,6 @@
33
| main.go:38:13:38:13 | 1 | main.go:38:7:38:20 | slice literal |
44
| main.go:38:16:38:16 | 2 | main.go:38:7:38:20 | slice literal |
55
| main.go:38:19:38:19 | 3 | main.go:38:7:38:20 | slice literal |
6-
| main.go:39:15:39:15 | s | main.go:39:8:39:25 | call to append |
7-
| main.go:39:18:39:18 | 4 | main.go:39:8:39:25 | call to append |
8-
| main.go:39:21:39:21 | 5 | main.go:39:8:39:25 | call to append |
9-
| main.go:39:24:39:24 | 6 | main.go:39:8:39:25 | call to append |
10-
| main.go:40:15:40:15 | s | main.go:40:8:40:23 | call to append |
11-
| main.go:40:18:40:19 | s1 | main.go:40:8:40:23 | call to append |
12-
| main.go:42:10:42:11 | s4 | main.go:38:2:38:2 | definition of s |
136
| main.go:47:20:47:21 | next key-value pair in range | main.go:47:2:50:2 | range statement[0] |
147
| main.go:47:20:47:21 | next key-value pair in range | main.go:47:2:50:2 | range statement[1] |
158
| main.go:47:20:47:21 | xs | main.go:47:2:50:2 | range statement[1] |

0 commit comments

Comments
 (0)