Fixed buffer overflow in read_config

Robin Müller · Robin Müller · commit 3a2957b6881f · 2014-08-23T21:52:32.000+02:00
diff --git a/src/configuraion.c b/src/configuraion.c
@@ -90,7 +90,7 @@ configuration_t read_config(const char *filename) {
   uint8_t i, j;
   for (i = 0; i < MAX_FINGERS; i++) {
     for (j = 0; j < DIRECTIONS_COUNT; j++) {
-      char ini_key[15];
+      char ini_key[16];
       sprintf(ini_key, "%d-fingers:%s", INDEX_TO_FINGER(i), directions[j]);
       fill_keys_array(&result.swipe_keys[i][j].keys, iniparser_getstring(ini, ini_key, NULL));
     }

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ configuration_t read_config(const char *filename) {`
`90`	`90`	`uint8_t i, j;`
`91`	`91`	`for (i = 0; i < MAX_FINGERS; i++) {`
`92`	`92`	`for (j = 0; j < DIRECTIONS_COUNT; j++) {`
`93`		`- char ini_key[15];`
	`93`	`+ char ini_key[16];`
`94`	`94`	`sprintf(ini_key, "%d-fingers:%s", INDEX_TO_FINGER(i), directions[j]);`
`95`	`95`	`fill_keys_array(&result.swipe_keys[i][j].keys, iniparser_getstring(ini, ini_key, NULL));`
`96`	`96`	`}`