Skip to content

Commit 4484101

Browse files
committed
The crawlPage viewport option will be passed directly to setViewport if it has a value
1 parent f7ec090 commit 4484101

File tree

2 files changed

+7
-13
lines changed

2 files changed

+7
-13
lines changed

src/api.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -432,10 +432,10 @@ async function pageSingleCrawlHandle(
432432
const { errorPageMap, browser } = extraConfig
433433

434434
const page = await browser.newPage()
435-
await page.setViewport({
436-
width: detailTarget.viewport?.width ?? 1280,
437-
height: detailTarget.viewport?.width ?? 1024
438-
})
435+
436+
if (detailTarget.viewport) {
437+
await page.setViewport(detailTarget.viewport)
438+
}
439439

440440
let response: HTTPResponse | null = null
441441
try {

src/types/api.ts

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { IncomingHttpHeaders } from 'node:http'
2-
import { Browser, HTTPResponse, Page, Protocol } from 'puppeteer'
2+
import { Browser, HTTPResponse, Page, Protocol, Viewport } from 'puppeteer'
33

44
import { AnyObject } from './common'
55

@@ -49,10 +49,7 @@ export interface CrawlPageDetailConfig extends CrawlCommonConfig {
4949
headers?: AnyObject | null
5050
cookies?: PageCookies | null
5151
priority?: number
52-
viewport?: {
53-
width?: number
54-
height?: number
55-
} | null
52+
viewport?: Viewport | null
5653
}
5754

5855
export interface CrawlDataDetailConfig extends CrawlCommonConfig {
@@ -80,10 +77,7 @@ export interface CrawlPageAdvancedConfig extends CrawlCommonConfig {
8077

8178
headers?: AnyObject
8279
cookies?: PageCookies
83-
viewport?: {
84-
width?: number
85-
height?: number
86-
}
80+
viewport?: Viewport
8781

8882
onCrawlItemComplete?: (crawlPageSingleRes: CrawlPageSingleRes) => void
8983
}

0 commit comments

Comments
 (0)