remove cursor checks - I'm not sure if cursor position changes can reliably indicate that the agent started processing a message

Author: hugodutka

lib/screentracker/conversation.go

@@ -21,7 +21,6 @@ type screenSnapshot struct {
 type AgentIO interface {
 	Write(data []byte) (int, error)
 	ReadScreen() string
-	Cursor() (int, int)
 }
 
 type ConversationConfig struct {
@@ -290,7 +289,6 @@ func (c *Conversation) writeMessageWithConfirmation(ctx context.Context, message
 
 	// wait for the screen to change after the carriage return is written
 	screenBeforeCarriageReturn := c.cfg.AgentIO.ReadScreen()
-	cursorBeforeCarriageReturnX, cursorBeforeCarriageReturnY := c.cfg.AgentIO.Cursor()
 	lastCarriageReturnTime := time.Time{}
 	if err := util.WaitFor(ctx, util.WaitTimeout{
 		Timeout:     15 * time.Second,
@@ -307,11 +305,8 @@ func (c *Conversation) writeMessageWithConfirmation(ctx context.Context, message
 		}
 		time.Sleep(25 * time.Millisecond)
 		screen := c.cfg.AgentIO.ReadScreen()
-		cursorX, cursorY := c.cfg.AgentIO.Cursor()
 
-		return screen != screenBeforeCarriageReturn ||
-			cursorX != cursorBeforeCarriageReturnX ||
-			cursorY != cursorBeforeCarriageReturnY, nil
+		return screen != screenBeforeCarriageReturn, nil
 	}); err != nil {
 		return xerrors.Errorf("failed to wait for processing to start: %w", err)
 	}

lib/screentracker/conversation_test.go

@@ -31,10 +31,6 @@ func (a *testAgent) ReadScreen() string {
 	return a.screen
 }
 
-func (a *testAgent) Cursor() (int, int) {
-	return 0, 0
-}
-
 func (a *testAgent) Write(data []byte) (int, error) {
 	return 0, nil
 }

lib/termexec/termexec.go

@@ -70,11 +70,6 @@ func (p *Process) ReadScreen() string {
 	return p.xp.State.String()
 }
 
-// Cursor returns the current cursor position.
-func (p *Process) Cursor() (int, int) {
-	return p.xp.State.Cursor()
-}
-
 // Write sends input to the process via the pseudo terminal.
 func (p *Process) Write(data []byte) (int, error) {
 	return p.xp.TerminalInPipe().Write(data)