chore: refactor names

Author: 35C4n0r

lib/httpapi/server.go

@@ -239,10 +239,10 @@ func NewServer(ctx context.Context, config ServerConfig) (*Server, error) {
 		GetTime: func() time.Time {
 			return time.Now()
 		},
-		SnapshotInterval:             snapshotInterval,
-		ScreenStabilityLength:        2 * time.Second,
-		FormatMessage:                formatMessage,
-		IsAgentReadyForInitialPrompt: isAgentReadyForInitialPrompt,
+		SnapshotInterval:      snapshotInterval,
+		ScreenStabilityLength: 2 * time.Second,
+		FormatMessage:         formatMessage,
+		ReadyForInitialPrompt: isAgentReadyForInitialPrompt,
 	}, config.InitialPrompt)
 	emitter := NewEventEmitter(1024)
 

lib/msgfmt/agent_readiness_test.go

@@ -9,16 +9,16 @@ import (
 
 func TestIsAgentReadyForInitialPrompt(t *testing.T) {
 	dir := "testdata/initialization"
-	agentTypes := []AgentType{AgentTypeClaude, AgentTypeGoose, AgentTypeAider, AgentTypeGemini, AgentTypeCopilot, AgentTypeAmp, AgentTypeCodex, AgentTypeCursor, AgentTypeAuggie, AgentTypeAmazonQ, AgentTypeOpencode, AgentTypeCustom}
+	agentTypes := []AgentType{AgentTypeClaude, AgentTypeGoose, AgentTypeAider, AgentTypeGemini, AgentTypeCopilot, AgentTypeAmp, AgentTypeCodex, AgentTypeCursor, AgentTypeAuggie, AgentTypeAmazonQ, AgentTypeOpencode}
 	for _, agentType := range agentTypes {
 		t.Run(string(agentType), func(t *testing.T) {
 			t.Run("ready", func(t *testing.T) {
 				cases, err := testdataDir.ReadDir(path.Join(dir, string(agentType), "ready"))
 				if err != nil {
-					t.Skipf("failed to read ready cases for agent type %s: %s", agentType, err)
+					t.Errorf("failed to read ready cases for agent type %s: %s", agentType, err)
 				}
 				if len(cases) == 0 {
-					t.Skipf("no ready cases found for agent type %s", agentType)
+					t.Errorf("no ready cases found for agent type %s", agentType)
 				}
 				for _, c := range cases {
 					if c.IsDir() {
@@ -35,10 +35,10 @@ func TestIsAgentReadyForInitialPrompt(t *testing.T) {
 			t.Run("not_ready", func(t *testing.T) {
 				cases, err := testdataDir.ReadDir(path.Join(dir, string(agentType), "not_ready"))
 				if err != nil {
-					t.Skipf("failed to read not_ready cases for agent type %s: %s", agentType, err)
+					t.Errorf("failed to read not_ready cases for agent type %s: %s", agentType, err)
 				}
 				if len(cases) == 0 {
-					t.Skipf("no not_ready cases found for agent type %s", agentType)
+					t.Errorf("no not_ready cases found for agent type %s", agentType)
 				}
 				for _, c := range cases {
 					if c.IsDir() {

lib/screentracker/conversation.go

@@ -41,8 +41,8 @@ type ConversationConfig struct {
 	// SkipSendMessageStatusCheck skips the check for whether the message can be sent.
 	// This is used in tests
 	SkipSendMessageStatusCheck bool
-	// IsAgentReadyForInitialPrompt detects whether the agent has initialized and is ready to accept the initial prompt
-	IsAgentReadyForInitialPrompt func(message string) bool
+	// ReadyForInitialPrompt detects whether the agent has initialized and is ready to accept the initial prompt
+	ReadyForInitialPrompt func(message string) bool
 }
 
 type ConversationRole string
@@ -80,8 +80,8 @@ type Conversation struct {
 	InitialPrompt string
 	// InitialPromptSent keeps track if the InitialPrompt has been successfully sent to the agents
 	InitialPromptSent bool
-	// AgentReadyForInitialPrompt keeps track if the agent is ready to accept the initial prompt
-	AgentReadyForInitialPrompt bool
+	// ReadyForInitialPrompt keeps track if the agent is ready to accept the initial prompt
+	ReadyForInitialPrompt bool
 }
 
 type ConversationStatus string
@@ -406,9 +406,9 @@ func (c *Conversation) statusInner() ConversationStatus {
 		}
 	}
 
-	if !c.InitialPromptSent && !c.AgentReadyForInitialPrompt {
-		if len(snapshots) > 0 && c.cfg.IsAgentReadyForInitialPrompt(snapshots[len(snapshots)-1].screen) {
-			c.AgentReadyForInitialPrompt = true
+	if !c.InitialPromptSent && !c.ReadyForInitialPrompt {
+		if len(snapshots) > 0 && c.cfg.ReadyForInitialPrompt(snapshots[len(snapshots)-1].screen) {
+			c.ReadyForInitialPrompt = true
 			return ConversationStatusStable
 		}
 		return ConversationStatusChanging

lib/screentracker/conversation_test.go

@@ -418,7 +418,7 @@ func TestInitialPromptReadiness(t *testing.T) {
 			SnapshotInterval:      1 * time.Second,
 			ScreenStabilityLength: 2 * time.Second,
 			AgentIO:               &testAgent{screen: "loading..."},
-			IsAgentReadyForInitialPrompt: func(message string) bool {
+			ReadyForInitialPrompt: func(message string) bool {
 				return message == "ready"
 			},
 		}
@@ -431,7 +431,7 @@ func TestInitialPromptReadiness(t *testing.T) {
 
 		// Even though screen is stable, status should be changing because agent is not ready
 		assert.Equal(t, changing, c.Status())
-		assert.False(t, c.AgentReadyForInitialPrompt)
+		assert.False(t, c.ReadyForInitialPrompt)
 		assert.False(t, c.InitialPromptSent)
 	})
 
@@ -441,7 +441,7 @@ func TestInitialPromptReadiness(t *testing.T) {
 			SnapshotInterval:      1 * time.Second,
 			ScreenStabilityLength: 2 * time.Second,
 			AgentIO:               &testAgent{screen: "loading..."},
-			IsAgentReadyForInitialPrompt: func(message string) bool {
+			ReadyForInitialPrompt: func(message string) bool {
 				return message == "ready"
 			},
 		}
@@ -458,7 +458,7 @@ func TestInitialPromptReadiness(t *testing.T) {
 		c.AddSnapshot("ready")
 		c.AddSnapshot("ready")
 		assert.Equal(t, stable, c.Status())
-		assert.True(t, c.AgentReadyForInitialPrompt)
+		assert.True(t, c.ReadyForInitialPrompt)
 		assert.False(t, c.InitialPromptSent)
 	})
 
@@ -468,7 +468,7 @@ func TestInitialPromptReadiness(t *testing.T) {
 			SnapshotInterval:      1 * time.Second,
 			ScreenStabilityLength: 2 * time.Second,
 			AgentIO:               &testAgent{screen: "loading..."},
-			IsAgentReadyForInitialPrompt: func(message string) bool {
+			ReadyForInitialPrompt: func(message string) bool {
 				return false // Agent never ready
 			},
 		}
@@ -481,7 +481,7 @@ func TestInitialPromptReadiness(t *testing.T) {
 
 		// Status should be stable because no initial prompt to wait for
 		assert.Equal(t, stable, c.Status())
-		assert.False(t, c.AgentReadyForInitialPrompt)
+		assert.False(t, c.ReadyForInitialPrompt)
 		assert.True(t, c.InitialPromptSent) // Set to true when initial prompt is empty
 	})
 
@@ -491,7 +491,7 @@ func TestInitialPromptReadiness(t *testing.T) {
 			SnapshotInterval:      1 * time.Second,
 			ScreenStabilityLength: 2 * time.Second,
 			AgentIO:               &testAgent{screen: "processing..."},
-			IsAgentReadyForInitialPrompt: func(message string) bool {
+			ReadyForInitialPrompt: func(message string) bool {
 				return false // Agent never ready
 			},
 		}
@@ -505,7 +505,7 @@ func TestInitialPromptReadiness(t *testing.T) {
 
 		// Status should be stable because initial prompt was already sent
 		assert.Equal(t, stable, c.Status())
-		assert.False(t, c.AgentReadyForInitialPrompt)
+		assert.False(t, c.ReadyForInitialPrompt)
 		assert.True(t, c.InitialPromptSent)
 	})
 
@@ -515,7 +515,7 @@ func TestInitialPromptReadiness(t *testing.T) {
 			SnapshotInterval:      1 * time.Second,
 			ScreenStabilityLength: 2 * time.Second,
 			AgentIO:               &testAgent{screen: "ready"},
-			IsAgentReadyForInitialPrompt: func(message string) bool {
+			ReadyForInitialPrompt: func(message string) bool {
 				return message == "ready"
 			},
 		}
@@ -526,20 +526,20 @@ func TestInitialPromptReadiness(t *testing.T) {
 		c.AddSnapshot("ready")
 		c.AddSnapshot("ready")
 		assert.Equal(t, stable, c.Status())
-		assert.True(t, c.AgentReadyForInitialPrompt)
+		assert.True(t, c.ReadyForInitialPrompt)
 
 		// After agent is detected as ready, normal status logic applies
 		// Screen changes should cause changing status
 		c.AddSnapshot("changing")
 		assert.Equal(t, changing, c.Status())
-		assert.True(t, c.AgentReadyForInitialPrompt)
+		assert.True(t, c.ReadyForInitialPrompt)
 
 		// Once screen stabilizes again, status should be stable
-		// AgentReadyForInitialPrompt remains true
+		// ReadyForInitialPrompt remains true
 		c.AddSnapshot("stable now")
 		c.AddSnapshot("stable now")
 		c.AddSnapshot("stable now")
 		assert.Equal(t, stable, c.Status())
-		assert.True(t, c.AgentReadyForInitialPrompt)
+		assert.True(t, c.ReadyForInitialPrompt)
 	})
 }