chore: rename requestlog->apidump

dannykopping · dannykopping · commit d021c47203be · 2026-01-15T15:05:42.000+02:00
Signed-off-by: Danny Kopping &lt;danny@coder.com&gt;
diff --git a/bridge_integration_test.go b/bridge_integration_test.go
@@ -26,7 +26,7 @@ import (
 	"github.com/coder/aibridge/config"
 	aibcontext "github.com/coder/aibridge/context"
 	"github.com/coder/aibridge/fixtures"
-	"github.com/coder/aibridge/intercept/requestlog"
+	"github.com/coder/aibridge/intercept/apidump"
 	"github.com/coder/aibridge/internal/testutil"
 	"github.com/coder/aibridge/mcp"
 	"github.com/coder/aibridge/provider"
@@ -1853,11 +1853,11 @@ func openaiCfg(url, key string) config.OpenAI {
 	}
 }
 
-func openaiCfgWithLogDir(url, key, logDir string) config.OpenAI {
+func openaiCfgWithAPIDump(url, key, dumpDir string) config.OpenAI {
 	return config.OpenAI{
-		BaseURL:       url,
-		Key:           key,
-		RequestLogDir: logDir,
+		BaseURL:    url,
+		Key:        key,
+		APIDumpDir: dumpDir,
 	}
 }
 
@@ -1868,15 +1868,15 @@ func anthropicCfg(url, key string) config.Anthropic {
 	}
 }
 
-func anthropicCfgWithLogDir(url, key, logDir string) config.Anthropic {
+func anthropicCfgWithAPIDump(url, key, dumpDir string) config.Anthropic {
 	return config.Anthropic{
-		BaseURL:       url,
-		Key:           key,
-		RequestLogDir: logDir,
+		BaseURL:    url,
+		Key:        key,
+		APIDumpDir: dumpDir,
 	}
 }
 
-func TestRequestLogging(t *testing.T) {
+func TestAPIDump(t *testing.T) {
 	t.Parallel()
 
 	cases := []struct {
@@ -1890,9 +1890,9 @@ func TestRequestLogging(t *testing.T) {
 			name:         config.ProviderAnthropic,
 			fixture:      fixtures.AntSimple,
 			providerName: config.ProviderAnthropic,
-			configureFunc: func(addr, logDir string, client aibridge.Recorder) (*aibridge.RequestBridge, error) {
+			configureFunc: func(addr, dumpDir string, client aibridge.Recorder) (*aibridge.RequestBridge, error) {
 				logger := slogtest.Make(t, &slogtest.Options{IgnoreErrors: false}).Leveled(slog.LevelDebug)
-				providers := []aibridge.Provider{provider.NewAnthropic(anthropicCfgWithLogDir(addr, apiKey, logDir), nil)}
+				providers := []aibridge.Provider{provider.NewAnthropic(anthropicCfgWithAPIDump(addr, apiKey, dumpDir), nil)}
 				return aibridge.NewRequestBridge(t.Context(), providers, client, mcp.NewServerProxyManager(nil, testTracer), logger, nil, testTracer)
 			},
 			createRequestFunc: createAnthropicMessagesReq,
@@ -1901,9 +1901,9 @@ func TestRequestLogging(t *testing.T) {
 			name:         config.ProviderOpenAI,
 			fixture:      fixtures.OaiChatSimple,
 			providerName: config.ProviderOpenAI,
-			configureFunc: func(addr, logDir string, client aibridge.Recorder) (*aibridge.RequestBridge, error) {
+			configureFunc: func(addr, dumpDir string, client aibridge.Recorder) (*aibridge.RequestBridge, error) {
 				logger := slogtest.Make(t, &slogtest.Options{IgnoreErrors: false}).Leveled(slog.LevelDebug)
-				providers := []aibridge.Provider{provider.NewOpenAI(openaiCfgWithLogDir(addr, apiKey, logDir))}
+				providers := []aibridge.Provider{provider.NewOpenAI(openaiCfgWithAPIDump(addr, apiKey, dumpDir))}
 				return aibridge.NewRequestBridge(t.Context(), providers, client, mcp.NewServerProxyManager(nil, testTracer), logger, nil, testTracer)
 			},
 			createRequestFunc: createOpenAIChatCompletionsReq,
@@ -1928,11 +1928,11 @@ func TestRequestLogging(t *testing.T) {
 			srv := newMockServer(ctx, t, files, nil)
 			t.Cleanup(srv.Close)
 
-			// Create temp dir for request logs.
-			logDir := t.TempDir()
+			// Create temp dir for API dumps.
+			dumpDir := t.TempDir()
 
 			recorderClient := &testutil.MockRecorder{}
-			b, err := tc.configureFunc(srv.URL, logDir, recorderClient)
+			b, err := tc.configureFunc(srv.URL, dumpDir, recorderClient)
 			require.NoError(t, err)
 
 			mockSrv := httptest.NewUnstartedServer(b)
@@ -1949,26 +1949,26 @@ func TestRequestLogging(t *testing.T) {
 			defer resp.Body.Close()
 			_, _ = io.ReadAll(resp.Body)
 
-			// Verify log files were created.
+			// Verify dump files were created.
 			interceptions := recorderClient.RecordedInterceptions()
 			require.Len(t, interceptions, 1)
 			interceptionID, err := uuid.Parse(interceptions[0].ID)
 			require.NoError(t, err)
 			model := interceptions[0].Model
 
-			reqLogFile := requestlog.LogPath(logDir, tc.providerName, model, interceptionID, "req")
-			respLogFile := requestlog.LogPath(logDir, tc.providerName, model, interceptionID, "resp")
+			reqDumpFile := apidump.DumpPath(dumpDir, tc.providerName, model, interceptionID, "req")
+			respDumpFile := apidump.DumpPath(dumpDir, tc.providerName, model, interceptionID, "resp")
 
-			// Verify request log exists and contains expected HTTP request format.
-			reqLogData, err := os.ReadFile(reqLogFile)
-			require.NoError(t, err, "request log file should exist")
-			require.Contains(t, string(reqLogData), "POST ")
-			require.Contains(t, string(reqLogData), "Host:")
+			// Verify request dump exists and contains expected HTTP request format.
+			reqDumpData, err := os.ReadFile(reqDumpFile)
+			require.NoError(t, err, "request dump file should exist")
+			require.Contains(t, string(reqDumpData), "POST ")
+			require.Contains(t, string(reqDumpData), "Host:")
 
-			// Verify response log exists and contains expected HTTP response format.
-			respLogData, err := os.ReadFile(respLogFile)
-			require.NoError(t, err, "response log file should exist")
-			require.Contains(t, string(respLogData), "200 OK")
+			// Verify response dump exists and contains expected HTTP response format.
+			respDumpData, err := os.ReadFile(respDumpFile)
+			require.NoError(t, err, "response dump file should exist")
+			require.Contains(t, string(respDumpData), "200 OK")
 
 			recorderClient.VerifyAllInterceptionsEnded(t)
 		})
diff --git a/config/config.go b/config/config.go
@@ -6,9 +6,9 @@ const (
 )
 
 type Anthropic struct {
-	BaseURL       string
-	Key           string
-	RequestLogDir string
+	BaseURL    string
+	Key        string
+	APIDumpDir string
 }
 
 type AWSBedrock struct {
@@ -21,7 +21,7 @@ type AWSBedrock struct {
 }
 
 type OpenAI struct {
-	BaseURL       string
-	Key           string
-	RequestLogDir string
+	BaseURL    string
+	Key        string
+	APIDumpDir string
 }
diff --git a/intercept/apidump/apidump.go b/intercept/apidump/apidump.go
@@ -1,4 +1,4 @@
-package requestlog
+package apidump
 
 import (
 	"bytes"
@@ -19,57 +19,57 @@ type MiddlewareNext = func(*http.Request) (*http.Response, error)
 // Middleware is an HTTP middleware function compatible with SDK WithMiddleware options.
 type Middleware = func(*http.Request, MiddlewareNext) (*http.Response, error)
 
-// LogPath returns the path to a request/response log file for a given interception.
+// DumpPath returns the path to a request/response dump file for a given interception.
 // kind should be "req" or "resp".
-func LogPath(baseDir, provider, model string, interceptionID uuid.UUID, kind string) string {
+func DumpPath(baseDir, provider, model string, interceptionID uuid.UUID, kind string) string {
 	safeModel := strings.ReplaceAll(model, "/", "-")
 	return filepath.Join(baseDir, provider, safeModel, fmt.Sprintf("%s.%s.txt", interceptionID, kind))
 }
 
-// NewMiddleware returns a middleware function that logs requests and responses to files.
-// Files are written to the path returned by LogPath.
+// NewMiddleware returns a middleware function that dumps requests and responses to files.
+// Files are written to the path returned by DumpPath.
 // If baseDir is empty, returns nil (no middleware).
 func NewMiddleware(baseDir, provider, model string, interceptionID uuid.UUID) Middleware {
 	if baseDir == "" {
 		return nil
 	}
 
-	logger := &logger{
+	d := &dumper{
 		baseDir:        baseDir,
 		provider:       provider,
 		model:          model,
 		interceptionID: interceptionID,
 	}
 
 	return func(req *http.Request, next MiddlewareNext) (*http.Response, error) {
-		if err := logger.logRequest(req); err != nil {
-			fmt.Fprintf(os.Stderr, "requestlog: failed to log request: %v\n", err)
+		if err := d.dumpRequest(req); err != nil {
+			fmt.Fprintf(os.Stderr, "apidump: failed to dump request: %v\n", err)
 		}
 
 		resp, err := next(req)
 		if err != nil {
 			return resp, err
 		}
 
-		if err := logger.logResponse(resp); err != nil {
-			fmt.Fprintf(os.Stderr, "requestlog: failed to log response: %v\n", err)
+		if err := d.dumpResponse(resp); err != nil {
+			fmt.Fprintf(os.Stderr, "apidump: failed to dump response: %v\n", err)
 		}
 
 		return resp, nil
 	}
 }
 
-type logger struct {
+type dumper struct {
 	baseDir        string
 	provider       string
 	model          string
 	interceptionID uuid.UUID
 }
 
-func (l *logger) logRequest(req *http.Request) error {
-	logPath := LogPath(l.baseDir, l.provider, l.model, l.interceptionID, "req")
-	if err := os.MkdirAll(filepath.Dir(logPath), 0o755); err != nil {
-		return fmt.Errorf("create log dir: %w", err)
+func (d *dumper) dumpRequest(req *http.Request) error {
+	dumpPath := DumpPath(d.baseDir, d.provider, d.model, d.interceptionID, "req")
+	if err := os.MkdirAll(filepath.Dir(dumpPath), 0o755); err != nil {
+		return fmt.Errorf("create dump dir: %w", err)
 	}
 
 	// Read and restore body
@@ -95,11 +95,11 @@ func (l *logger) logRequest(req *http.Request) error {
 	fmt.Fprintf(&buf, "\r\n")
 	buf.Write(prettyPrintJSON(bodyBytes))
 
-	return os.WriteFile(logPath, buf.Bytes(), 0o644)
+	return os.WriteFile(dumpPath, buf.Bytes(), 0o644)
 }
 
-func (l *logger) logResponse(resp *http.Response) error {
-	logPath := LogPath(l.baseDir, l.provider, l.model, l.interceptionID, "resp")
+func (d *dumper) dumpResponse(resp *http.Response) error {
+	dumpPath := DumpPath(d.baseDir, d.provider, d.model, d.interceptionID, "resp")
 
 	// Read and restore body
 	var bodyBytes []byte
@@ -123,7 +123,7 @@ func (l *logger) logResponse(resp *http.Response) error {
 	fmt.Fprintf(&buf, "\r\n")
 	buf.Write(prettyPrintJSON(bodyBytes))
 
-	return os.WriteFile(logPath, buf.Bytes(), 0o644)
+	return os.WriteFile(dumpPath, buf.Bytes(), 0o644)
 }
 
 // prettyPrintJSON returns indented JSON if body is valid JSON, otherwise returns body as-is.
diff --git a/intercept/chatcompletions/base.go b/intercept/chatcompletions/base.go
@@ -11,7 +11,7 @@ import (
 	aibcontext "github.com/coder/aibridge/context"
 	"github.com/coder/aibridge/mcp"
 	"github.com/coder/aibridge/recorder"
-	"github.com/coder/aibridge/intercept/requestlog"
+	"github.com/coder/aibridge/intercept/apidump"
 	"github.com/coder/aibridge/tracing"
 	"github.com/google/uuid"
 	"github.com/openai/openai-go/v3"
@@ -38,8 +38,8 @@ type interceptionBase struct {
 func (i *interceptionBase) newCompletionsService() openai.ChatCompletionService {
 	opts := []option.RequestOption{option.WithAPIKey(i.cfg.Key), option.WithBaseURL(i.cfg.BaseURL)}
 
-	// Add request logging if configured
-	if mw := requestlog.NewMiddleware(i.cfg.RequestLogDir, config.ProviderOpenAI, i.Model(), i.id); mw != nil {
+	// Add API dump middleware if configured
+	if mw := apidump.NewMiddleware(i.cfg.APIDumpDir, config.ProviderOpenAI, i.Model(), i.id); mw != nil {
 		opts = append(opts, option.WithMiddleware(mw))
 	}
 
diff --git a/intercept/messages/base.go b/intercept/messages/base.go
@@ -21,7 +21,7 @@ import (
 	aibcontext "github.com/coder/aibridge/context"
 	"github.com/coder/aibridge/mcp"
 	"github.com/coder/aibridge/recorder"
-	"github.com/coder/aibridge/intercept/requestlog"
+	"github.com/coder/aibridge/intercept/apidump"
 	"github.com/coder/aibridge/tracing"
 
 	"github.com/google/uuid"
@@ -154,8 +154,8 @@ func (i *interceptionBase) newMessagesService(ctx context.Context, opts ...optio
 	opts = append(opts, option.WithAPIKey(i.cfg.Key))
 	opts = append(opts, option.WithBaseURL(i.cfg.BaseURL))
 
-	// Add request logging if configured
-	if mw := requestlog.NewMiddleware(i.cfg.RequestLogDir, aibconfig.ProviderAnthropic, i.Model(), i.id); mw != nil {
+	// Add API dump middleware if configured
+	if mw := apidump.NewMiddleware(i.cfg.APIDumpDir, aibconfig.ProviderAnthropic, i.Model(), i.id); mw != nil {
 		opts = append(opts, option.WithMiddleware(mw))
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -6,9 +6,9 @@ const (`
`6`	`6`	`)`
`7`	`7`
`8`	`8`	`type Anthropic struct {`
`9`		`- BaseURL string`
`10`		`- Key string`
`11`		`- RequestLogDir string`
	`9`	`+ BaseURL string`
	`10`	`+ Key string`
	`11`	`+ APIDumpDir string`
`12`	`12`	`}`
`13`	`13`
`14`	`14`	`type AWSBedrock struct {`
`@@ -21,7 +21,7 @@ type AWSBedrock struct {`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`type OpenAI struct {`
`24`		`- BaseURL string`
`25`		`- Key string`
`26`		`- RequestLogDir string`
	`24`	`+ BaseURL string`
	`25`	`+ Key string`
	`26`	`+ APIDumpDir string`
`27`	`27`	`}`