Skip to content

Commit 03b2938

Browse files
refactor
1 parent 926f923 commit 03b2938

File tree

2 files changed

+12
-21
lines changed

2 files changed

+12
-21
lines changed

boundary.go

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,11 @@ func (b *Boundary) Start() error {
6262
}
6363

6464
// Start proxy server in background
65-
go func() {
66-
err := b.proxyServer.Start(b.ctx)
67-
if err != nil {
68-
b.logger.Error("Proxy server error", "error", err)
69-
}
70-
}()
65+
err = b.proxyServer.Start()
66+
if err != nil {
67+
b.logger.Error("Proxy server error", "error", err)
68+
return err
69+
}
7170

7271
// Give proxy time to start
7372
time.Sleep(100 * time.Millisecond)
@@ -90,4 +89,4 @@ func (b *Boundary) Close() error {
9089

9190
// Close jailer
9291
return b.jailer.Close()
93-
}
92+
}

proxy/proxy_test.go

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,9 @@ func TestProxyServerBasicHTTP(t *testing.T) {
5959
TLSConfig: tlsConfig,
6060
})
6161

62-
// Start server in goroutine
63-
serverDone := make(chan error, 1)
64-
go func() {
65-
serverDone <- server.Start()
66-
}()
62+
// Start server
63+
err = server.Start()
64+
require.NoError(t, err)
6765

6866
// Give server time to start
6967
time.Sleep(100 * time.Millisecond)
@@ -107,8 +105,6 @@ func TestProxyServerBasicHTTP(t *testing.T) {
107105

108106
err = server.Stop()
109107
require.NoError(t, err)
110-
err = <-serverDone
111-
require.NoError(t, err)
112108
}
113109

114110
// TestProxyServerBasicHTTPS tests basic HTTPS request handling
@@ -161,11 +157,9 @@ func TestProxyServerBasicHTTPS(t *testing.T) {
161157
TLSConfig: tlsConfig,
162158
})
163159

164-
// Start server in goroutine
165-
serverDone := make(chan error, 1)
166-
go func() {
167-
serverDone <- server.Start()
168-
}()
160+
// Start server
161+
err = server.Start()
162+
require.NoError(t, err)
169163

170164
// Give server time to start
171165
time.Sleep(100 * time.Millisecond)
@@ -205,6 +199,4 @@ func TestProxyServerBasicHTTPS(t *testing.T) {
205199

206200
err = server.Stop()
207201
require.NoError(t, err)
208-
err = <-serverDone
209-
require.NoError(t, err)
210202
}

0 commit comments

Comments
 (0)