instead of failing skip tests that need root when you don't have it

bcpeinhardt · bcpeinhardt · commit 3ab9c01757a5 · 2025-09-10T14:54:25.000-05:00
diff --git a/cli/cli_test.go b/cli/cli_test.go
@@ -8,10 +8,10 @@ import (
 	"github.com/coder/serpent"
 )
 
-func ensureSudo(t *testing.T) {
+func ensureRoot(t *testing.T) {
 	t.Helper()
 	if os.Getgid() != 0 {
-		t.Fatal("test requires root priviledges")
+		t.Skip("skipping test because no root privileges")
 	}
 }
 
@@ -86,7 +86,7 @@ func TestPtySetupWorks(t *testing.T) {
 }
 
 func TestCurlGithub(t *testing.T) {
-	ensureSudo(t)
+	ensureRoot(t)
 
 	cmd := NewCommand()
 	inv := cmd.Invoke("--allow", "\"github.com\"", "--", "curl", "https://github.com")

Original file line number	Diff line number	Diff line change
`@@ -8,10 +8,10 @@ import (`
`8`	`8`	`"github.com/coder/serpent"`
`9`	`9`	`)`
`10`	`10`
`11`		`-func ensureSudo(t *testing.T) {`
	`11`	`+func ensureRoot(t *testing.T) {`
`12`	`12`	`t.Helper()`
`13`	`13`	`if os.Getgid() != 0 {`
`14`		`- t.Fatal("test requires root priviledges")`
	`14`	`+ t.Skip("skipping test because no root privileges")`
`15`	`15`	`}`
`16`	`16`	`}`
`17`	`17`
`@@ -86,7 +86,7 @@ func TestPtySetupWorks(t *testing.T) {`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`func TestCurlGithub(t *testing.T) {`
`89`		`- ensureSudo(t)`
	`89`	`+ ensureRoot(t)`
`90`	`90`
`91`	`91`	`cmd := NewCommand()`
`92`	`92`	`inv := cmd.Invoke("--allow", "\"github.com\"", "--", "curl", "https://github.com")`