Rename EvaluateWithRule to Evaluate and fix test compatibility

- Rename RuleEngine.EvaluateWithRule() to Evaluate() for simpler API
- Remove old boolean-only Evaluate() method
- Update proxy.go to use renamed Evaluate() method
- Fix rules tests to work with EvaluationResult struct
- Clean up formatting and remove extra blank lines
- All tests pass with unified evaluation method

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: f0ssel

proxy/proxy.go

@@ -106,7 +106,7 @@ func (p *ProxyServer) Stop() error {
 // handleHTTP handles regular HTTP requests
 func (p *ProxyServer) handleHTTP(w http.ResponseWriter, r *http.Request) {
 	// Check if request should be allowed
-	result := p.ruleEngine.EvaluateWithRule(r.Method, r.URL.String())
+	result := p.ruleEngine.Evaluate(r.Method, r.URL.String())
 
 	// Audit the request
 	auditReq := audit.HTTPRequestToAuditRequest(r)
@@ -132,7 +132,7 @@ func (p *ProxyServer) handleHTTPS(w http.ResponseWriter, r *http.Request) {
 	}
 
 	// Check if request should be allowed
-	result := p.ruleEngine.EvaluateWithRule(r.Method, fullURL)
+	result := p.ruleEngine.Evaluate(r.Method, fullURL)
 
 	// Audit the request
 	auditReq := &audit.Request{

rules/rules.go

@@ -6,15 +6,13 @@ import (
 	"strings"
 )
 
-
 // Rule represents an allow rule with optional HTTP method restrictions
 type Rule struct {
 	Pattern string          // wildcard pattern for matching
 	Methods map[string]bool // nil means all methods allowed
 	Raw     string          // rule string for logging
 }
 
-
 // Matches checks if the rule matches the given method and URL using wildcard patterns
 func (r *Rule) Matches(method, url string) bool {
 	// Check method if specified
@@ -127,21 +125,8 @@ type EvaluationResult struct {
 	Rule    string // The rule that matched (if any)
 }
 
-// Evaluate evaluates a request against all allow rules and returns true if allowed
-func (re *RuleEngine) Evaluate(method, url string) bool {
-	// Check if any allow rule matches
-	for _, rule := range re.rules {
-		if rule.Matches(method, url) {
-			return true
-		}
-	}
-
-	// Default deny if no allow rules match
-	return false
-}
-
-// EvaluateWithRule evaluates a request and returns both result and matching rule
-func (re *RuleEngine) EvaluateWithRule(method, url string) EvaluationResult {
+// Evaluate evaluates a request and returns both result and matching rule
+func (re *RuleEngine) Evaluate(method, url string) EvaluationResult {
 	// Check if any allow rule matches
 	for _, rule := range re.rules {
 		if rule.Matches(method, url) {

rules/rules_test.go

@@ -157,7 +157,7 @@ func TestWildcardMatch(t *testing.T) {
 		// Basic exact matches
 		{"exact match", "github.com", "github.com", true},
 		{"no match", "github.com", "gitlab.com", false},
-		
+
 		// Wildcard * tests
 		{"star matches all", "*", "anything.com", true},
 		{"star matches empty", "*", "", true},
@@ -251,8 +251,8 @@ func TestRuleEngine(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			result := engine.Evaluate(tt.method, tt.url)
-			if result != tt.expected {
-				t.Errorf("expected %v, got %v", tt.expected, result)
+			if result.Allowed != tt.expected {
+				t.Errorf("expected %v, got %v", tt.expected, result.Allowed)
 			}
 		})
 	}
@@ -287,9 +287,9 @@ func TestRuleEngineWildcardRules(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			result := engine.Evaluate(tt.method, tt.url)
-			if result != tt.expected {
-				t.Errorf("expected %v, got %v", tt.expected, result)
+			if result.Allowed != tt.expected {
+				t.Errorf("expected %v, got %v", tt.expected, result.Allowed)
 			}
 		})
 	}
-}
+}