Skip to content

Commit d62fac5

Browse files
blink-so[bot]f0ssel
andcommitted
fix: remove unused gid variable in macOS implementation
Since we're keeping the jail group instead of using the original user's group, we don't need to parse SUDO_GID anymore. Co-authored-by: f0ssel <[email protected]>
1 parent 0283fdc commit d62fac5

File tree

1 file changed

+7
-12
lines changed

1 file changed

+7
-12
lines changed

network/macos.go

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -110,19 +110,14 @@ func (m *MacOSNetJail) Execute(command []string, extraEnv map[string]string) err
110110
if err != nil {
111111
m.logger.Warn("Invalid SUDO_UID, subprocess will run as root", "sudo_uid", sudoUID, "error", err)
112112
} else {
113-
gid, err := strconv.Atoi(sudoGID)
114-
if err != nil {
115-
m.logger.Warn("Invalid SUDO_GID, subprocess will run as root", "sudo_gid", sudoGID, "error", err)
116-
} else {
117-
// Use original user ID but KEEP the jail group for network isolation
118-
cmd.SysProcAttr = &syscall.SysProcAttr{
119-
Credential: &syscall.Credential{
120-
Uid: uint32(uid),
121-
Gid: uint32(m.groupID), // Keep jail group, not original user's group
122-
},
123-
}
124-
m.logger.Debug("Dropping privileges to original user with jail group", "uid", uid, "jail_gid", m.groupID)
113+
// Use original user ID but KEEP the jail group for network isolation
114+
cmd.SysProcAttr = &syscall.SysProcAttr{
115+
Credential: &syscall.Credential{
116+
Uid: uint32(uid),
117+
Gid: uint32(m.groupID), // Keep jail group, not original user's group
118+
},
125119
}
120+
m.logger.Debug("Dropping privileges to original user with jail group", "uid", uid, "jail_gid", m.groupID)
126121
}
127122
}
128123
} else {

0 commit comments

Comments
 (0)