Fix command output, proxy setup, and HTTPS forwarding #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink-so
bot
changed the title
CONNECT requests coming through TLS termination were incorrectly forwarded as regular HTTP requests instead of being handled by handleConnect. This caused 400 errors when clients used CONNECT. The fix adds proper CONNECT detection in handleDecryptedHTTPS, matching the behavior in handleHTTP.
HTTPS_PROXY should use http:// to establish CONNECT tunnels to the proxy, not https://. This is the standard approach for HTTP proxies handling HTTPS traffic via CONNECT. The proxy will still perform TLS termination on the tunneled connections for full request visibility.
- Add read timeout to detect clients that don't send HTTP requests - Add detailed TLS connection state logging - Better error handling for timeout scenarios This should help diagnose why CONNECT tunnels hang after TLS handshake.
Replace SetReadTimeout (which doesn't exist) with SetReadDeadline. Also reset the deadline after each successful request to allow multiple requests on the same TLS connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes multiple issues with command execution and proxy behavior: