refactor: simplify mini.files integration and remove redundant visual mode logic

- Remove visual mode detection from _get_mini_files_selection() since visual mode is now handled by _get_mini_files_selection_with_range()
- Remove visual mode tests that are no longer applicable
- Keep only normal mode (single file) functionality in _get_mini_files_selection()
- Tests now focus on the actual usage patterns

Author: jdurand

lua/claudecode/integrations.lua

@@ -316,56 +316,25 @@ function M._get_mini_files_selection()
   local bufnr = vim.api.nvim_get_current_buf()
 
 
-  -- Check if we're in visual mode for multi-selection
-  local mode = vim.fn.mode()
-  if mode == "V" or mode == "v" or mode == "\22" then
-    -- Visual mode: get visual range
-    local visual_commands = require("claudecode.visual_commands")
-    local start_line, end_line = visual_commands.get_visual_range()
-
-    -- Process each line in the visual selection
-    for line = start_line, end_line do
-      local entry_ok, entry = pcall(mini_files.get_fs_entry, bufnr, line)
-      
-      if entry_ok and entry and entry.path and entry.path ~= "" then
-        -- Extract real filesystem path from mini.files buffer path
-        local real_path = entry.path
-        -- Remove mini.files buffer protocol prefix if present
-        if real_path:match("^minifiles://") then
-          real_path = real_path:gsub("^minifiles://[^/]*/", "")
-        end
+  -- Normal mode: get file under cursor
+  local entry_ok, entry = pcall(mini_files.get_fs_entry, bufnr)
+  if not entry_ok or not entry then
+    return {}, "Failed to get entry from mini.files"
+  end
 
-        -- Validate that the path exists
-        if vim.fn.filereadable(real_path) == 1 or vim.fn.isdirectory(real_path) == 1 then
-          table.insert(files, real_path)
-        end
-      end
+  if entry.path and entry.path ~= "" then
+    -- Extract real filesystem path from mini.files buffer path
+    local real_path = entry.path
+    -- Remove mini.files buffer protocol prefix if present
+    if real_path:match("^minifiles://") then
+      real_path = real_path:gsub("^minifiles://[^/]*/", "")
     end
 
-    if #files > 0 then
-      return files, nil
-    end
-  else
-    -- Normal mode: get file under cursor
-    local entry_ok, entry = pcall(mini_files.get_fs_entry, bufnr)
-    if not entry_ok or not entry then
-      return {}, "Failed to get entry from mini.files"
-    end
-
-    if entry.path and entry.path ~= "" then
-      -- Extract real filesystem path from mini.files buffer path
-      local real_path = entry.path
-      -- Remove mini.files buffer protocol prefix if present
-      if real_path:match("^minifiles://") then
-        real_path = real_path:gsub("^minifiles://[^/]*/", "")
-      end
-      
-      -- Validate that the path exists
-      if vim.fn.filereadable(real_path) == 1 or vim.fn.isdirectory(real_path) == 1 then
-        return { real_path }, nil
-      else
-        return {}, "Invalid file or directory path: " .. real_path
-      end
+    -- Validate that the path exists
+    if vim.fn.filereadable(real_path) == 1 or vim.fn.isdirectory(real_path) == 1 then
+      return { real_path }, nil
+    else
+      return {}, "Invalid file or directory path: " .. real_path
     end
   end
 

tests/unit/mini_files_integration_spec.lua

@@ -150,148 +150,6 @@ describe("mini.files integration", function()
       end
     end)
 
-    it("should handle mini.files buffer paths in visual mode", function()
-      mock_vim.fn.mode = function()
-        return "V" -- Visual line mode
-      end
-
-      -- Mock mini.files module that returns buffer-style paths
-      local mock_mini_files = {
-        get_fs_entry = function(buf_id, line)
-          if buf_id ~= 1 then
-            return nil
-          end
-          
-          if line == 1 then
-            return { path = "minifiles://42//Users/test/project/visual1.lua" }
-          elseif line == 2 then
-            return { path = "minifiles://42//Users/test/project/visual2.txt" }
-          elseif line == 3 then
-            return { path = "minifiles://42//Users/test/project/src" }
-          end
-          return nil
-        end,
-      }
-      package.loaded["mini.files"] = mock_mini_files
-
-      local files, err = integrations._get_mini_files_selection()
-
-      expect(err).to_be_nil()
-      expect(files).to_be_table()
-      expect(#files).to_be(3)
-      expect(files[1]).to_be("/Users/test/project/visual1.lua") 
-      expect(files[2]).to_be("/Users/test/project/visual2.txt")
-      expect(files[3]).to_be("/Users/test/project/src")
-    end)
-
-    it("should get multiple files in visual mode", function()
-      mock_vim.fn.mode = function()
-        return "V" -- Visual line mode
-      end
-
-      -- Mock mini.files module
-      local mock_mini_files = {
-        get_fs_entry = function(buf_id, line)
-          -- Verify buffer ID is passed correctly
-          if buf_id ~= 1 then
-            return nil
-          end
-          
-          if line == 1 then
-            return { path = "/Users/test/project/file1.lua" }
-          elseif line == 2 then
-            return { path = "/Users/test/project/file2.lua" }
-          elseif line == 3 then
-            return { path = "/Users/test/project/src" }
-          end
-          return nil
-        end,
-      }
-      package.loaded["mini.files"] = mock_mini_files
-
-      local files, err = integrations._get_mini_files_selection()
-
-      expect(err).to_be_nil()
-      expect(files).to_be_table()
-      expect(#files).to_be(3)
-      expect(files[1]).to_be("/Users/test/project/file1.lua")
-      expect(files[2]).to_be("/Users/test/project/file2.lua")
-      expect(files[3]).to_be("/Users/test/project/src")
-    end)
-
-    it("should filter out invalid files in visual mode", function()
-      mock_vim.fn.mode = function()
-        return "V" -- Visual line mode
-      end
-
-      -- Mock mini.files module
-      local mock_mini_files = {
-        get_fs_entry = function(buf_id, line)
-          if line == 1 then
-            return { path = "/Users/test/project/valid.lua" }
-          elseif line == 2 then
-            return { path = "/Users/test/project/invalid.xyz" } -- Won't pass filereadable/isdirectory
-          elseif line == 3 then
-            return { path = "/Users/test/project/src" }
-          end
-          return nil
-        end,
-      }
-      package.loaded["mini.files"] = mock_mini_files
-
-      local files, err = integrations._get_mini_files_selection()
-
-      expect(err).to_be_nil()
-      expect(files).to_be_table()
-      expect(#files).to_be(2) -- Only valid.lua and src
-      expect(files[1]).to_be("/Users/test/project/valid.lua")
-      expect(files[2]).to_be("/Users/test/project/src")
-    end)
-
-    it("should handle visual mode with buffer ID correctly", function()
-      mock_vim.fn.mode = function()
-        return "v" -- Visual character mode
-      end
-
-      -- Mock different buffer ID to test parameter passing
-      mock_vim.api.nvim_get_current_buf = function()
-        return 42 -- Different buffer ID
-      end
-
-      -- Mock mini.files module that validates buffer ID
-      local mock_mini_files = {
-        get_fs_entry = function(buf_id, line)
-          -- Should receive buffer ID 42
-          if buf_id ~= 42 then
-            error("Expected buffer ID 42, got " .. tostring(buf_id))
-          end
-          
-          if line == 1 then
-            return { path = "/Users/test/project/selected1.lua" }
-          elseif line == 2 then
-            return { path = "/Users/test/project/selected2.txt" }
-          elseif line == 3 then
-            return { path = "/Users/test/project/selected3.lua" }
-          end
-          return nil
-        end,
-      }
-      package.loaded["mini.files"] = mock_mini_files
-
-      local files, err = integrations._get_mini_files_selection()
-
-      expect(err).to_be_nil()
-      expect(files).to_be_table()
-      expect(#files).to_be(3)
-      expect(files[1]).to_be("/Users/test/project/selected1.lua")
-      expect(files[2]).to_be("/Users/test/project/selected2.txt")
-      expect(files[3]).to_be("/Users/test/project/selected3.lua")
-      
-      -- Reset buffer ID for other tests
-      mock_vim.api.nvim_get_current_buf = function()
-        return 1
-      end
-    end)
 
     it("should handle empty entry under cursor", function()
       -- Mock mini.files module
@@ -375,25 +233,6 @@ describe("mini.files integration", function()
       expect(#files).to_be(0)
     end)
 
-    it("should handle visual mode with no valid entries", function()
-      mock_vim.fn.mode = function()
-        return "V" -- Visual line mode
-      end
-
-      -- Mock mini.files module
-      local mock_mini_files = {
-        get_fs_entry = function(buf_id, line)
-          return nil -- No entries
-        end,
-      }
-      package.loaded["mini.files"] = mock_mini_files
-
-      local files, err = integrations._get_mini_files_selection()
-
-      expect(err).to_be("No file found under cursor")
-      expect(files).to_be_table()
-      expect(#files).to_be(0)
-    end)
   end)
 
   describe("get_selected_files_from_tree", function()