remember to stage changes

Author: bcpeinhardt

api/api.go

@@ -16,6 +16,8 @@ import (
 	"github.com/coder/code-marketplace/storage"
 )
 
+const MaxPageSizeDefault int = 200
+
 // QueryRequest implements an untyped object.  It is the data sent to the API to
 // query for extensions.
 // https://github.com/microsoft/vscode/blob/a69f95fdf3dc27511517eef5ff62b21c7a418015/src/vs/platform/extensionManagement/common/extensionGalleryService.ts#L338-L342
@@ -74,6 +76,10 @@ func New(options *Options) *API {
 		options.RateLimit = 512
 	}
 
+	if options.MaxPageSize == 0 {
+		options.MaxPageSize = MaxPageSizeDefault
+	}
+
 	r := chi.NewRouter()
 
 	r.Use(

api/api_test.go

@@ -119,8 +119,8 @@ func TestAPI(t *testing.T) {
 				}},
 			},
 			Response: &httpapi.ErrorResponse{
-				Message: "Invalid page size",
-				Detail:  "Check that the page size is between zero and fifty",
+				Message: "The page size must be between 0 and 200",
+				Detail:  "Contact an administrator to increase the page size",
 			},
 		},
 		{
@@ -255,9 +255,10 @@ func TestAPI(t *testing.T) {
 
 			logger := slogtest.Make(t, &slogtest.Options{IgnoreErrors: true}).Leveled(slog.LevelDebug)
 			apiServer := api.New(&api.Options{
-				Database: testutil.NewMockDB(exts),
-				Storage:  testutil.NewMockStorage(),
-				Logger:   logger,
+				Database:    testutil.NewMockDB(exts),
+				Storage:     testutil.NewMockStorage(),
+				Logger:      logger,
+				MaxPageSize: api.MaxPageSizeDefault,
 			})
 
 			server := httptest.NewServer(apiServer.Handler)

cli/server.go

@@ -21,8 +21,6 @@ import (
 	"github.com/coder/code-marketplace/storage"
 )
 
-const maxPageSizeDefault int = 200
-
 func server() *cobra.Command {
 	var (
 		address           string
@@ -140,7 +138,7 @@ func server() *cobra.Command {
 	}
 
 	cmd.Flags().StringVar(&extdir, "extensions-dir", "", "The path to extensions.")
-	cmd.Flags().IntVar(&maxpagesize, "max-page-size", maxPageSizeDefault, "The maximum number of pages to request")
+	cmd.Flags().IntVar(&maxpagesize, "max-page-size", api.MaxPageSizeDefault, "The maximum number of pages to request")
 	cmd.Flags().StringVar(&artifactory, "artifactory", "", "Artifactory server URL.")
 	cmd.Flags().StringVar(&repo, "repo", "", "Artifactory repository.")
 	cmd.Flags().StringVar(&address, "address", "127.0.0.1:3001", "The address on which to serve the marketplace API.")