Close all file readers

code-asher · code-asher · commit 6fe67ec052b6 · 2022-09-29T12:46:00.000-05:00
diff --git a/database/nodb.go b/database/nodb.go
@@ -48,6 +48,7 @@ func (db *NoDB) GetExtensionAssetPath(ctx context.Context, asset *Asset, baseURL
 	if err != nil {
 		return "", err
 	}
+	defer reader.Close()
 
 	manifest, err := parseVSIXManifest(reader)
 	if err != nil {
@@ -86,6 +87,7 @@ func (db *NoDB) GetExtensions(ctx context.Context, filter Filter, flags Flag, ba
 				db.Logger.Error(ctx, "Unable to read extension manifest", slog.Error(err))
 				continue
 			}
+			defer reader.Close()
 
 			manifest, err := parseVSIXManifest(reader)
 			if err != nil {
@@ -353,6 +355,7 @@ func (db *NoDB) getVersions(ctx context.Context, ext *noDBExtension, flags Flag,
 			db.Logger.Error(ctx, "Unable to read version manifest", slog.Error(err))
 			continue
 		}
+		defer reader.Close()
 
 		manifest, err := parseVSIXManifest(reader)
 		if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,7 @@ func (db NoDB) GetExtensionAssetPath(ctx context.Context, asset Asset, baseURL`
`48`	`48`	`if err != nil {`
`49`	`49`	`return "", err`
`50`	`50`	`}`
	`51`	`+ defer reader.Close()`
`51`	`52`
`52`	`53`	`manifest, err := parseVSIXManifest(reader)`
`53`	`54`	`if err != nil {`
`@@ -86,6 +87,7 @@ func (db *NoDB) GetExtensions(ctx context.Context, filter Filter, flags Flag, ba`
`86`	`87`	`db.Logger.Error(ctx, "Unable to read extension manifest", slog.Error(err))`
`87`	`88`	`continue`
`88`	`89`	`}`
	`90`	`+ defer reader.Close()`
`89`	`91`
`90`	`92`	`manifest, err := parseVSIXManifest(reader)`
`91`	`93`	`if err != nil {`
`@@ -353,6 +355,7 @@ func (db NoDB) getVersions(ctx context.Context, ext noDBExtension, flags Flag,`
`353`	`355`	`db.Logger.Error(ctx, "Unable to read version manifest", slog.Error(err))`
`354`	`356`	`continue`
`355`	`357`	`}`
	`358`	`+ defer reader.Close()`
`356`	`359`
`357`	`360`	`manifest, err := parseVSIXManifest(reader)`
`358`	`361`	`if err != nil {`