add a comment to prevent copy into memory

Emyrk · Emyrk · commit adb3c6626e51 · 2024-12-13T09:43:54.000-06:00
diff --git a/storage/artifactory.go b/storage/artifactory.go
@@ -299,6 +299,8 @@ func (s *Artifactory) Open(ctx context.Context, fp string) (fs.File, error) {
 		}
 	}
 
+	// TODO: Do no copy the bytes into memory, stream them rather than
+	// storing the entire file into memory.
 	f := mem.NewFileHandle(mem.CreateFile(fp))
 	_, err = io.Copy(f, resp)
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -299,6 +299,8 @@ func (s *Artifactory) Open(ctx context.Context, fp string) (fs.File, error) {`
`299`	`299`	`}`
`300`	`300`	`}`
`301`	`301`
	`302`	`+ // TODO: Do no copy the bytes into memory, stream them rather than`
	`303`	`+ // storing the entire file into memory.`
`302`	`304`	`f := mem.NewFileHandle(mem.CreateFile(fp))`
`303`	`305`	`_, err = io.Copy(f, resp)`
`304`	`306`	`if err != nil {`