Skip to content

Commit 0f18d1f

Browse files
committed
fix: update import in channel.ts getSystemShell
1 parent b71c506 commit 0f18d1f

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

lib/vscode/src/vs/server/node/channel.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import * as terminal from 'vs/workbench/contrib/terminal/common/remoteTerminalCh
3030
import { IShellLaunchConfig, ITerminalEnvironment, ITerminalLaunchError } from 'vs/workbench/contrib/terminal/common/terminal';
3131
import { TerminalDataBufferer } from 'vs/workbench/contrib/terminal/common/terminalDataBuffering';
3232
import * as terminalEnvironment from 'vs/workbench/contrib/terminal/common/terminalEnvironment';
33-
import { getSystemShell } from 'vs/workbench/contrib/terminal/node/terminal';
33+
import { getSystemShell } from 'vs/base/node/shell';
3434
import { getMainProcessParentEnv } from 'vs/workbench/contrib/terminal/node/terminalEnvironment';
3535
import { TerminalProcess } from 'vs/workbench/contrib/terminal/node/terminalProcess';
3636
import { AbstractVariableResolverService } from 'vs/workbench/services/configurationResolver/common/variableResolver';
@@ -263,6 +263,7 @@ export class ExtensionEnvironmentChannel implements IServerChannel {
263263
workspaceStorageHome: this.environment.workspaceStorageHome,
264264
userHome: this.environment.userHome,
265265
os: platform.OS,
266+
marks: []
266267
};
267268
}
268269

@@ -681,7 +682,7 @@ export class TerminalProviderChannel implements IServerChannel<RemoteAgentConnec
681682
const resolverService = new VariableResolverService(remoteAuthority, args, process.env as platform.IProcessEnvironment);
682683
const resolver = terminalEnvironment.createVariableResolver(activeWorkspace, resolverService);
683684

684-
const getDefaultShellAndArgs = (): { executable: string; args: string[] | string } => {
685+
const getDefaultShellAndArgs = async (): Promise<{ executable: string; args: string[] | string }> => {
685686
if (shellLaunchConfig.executable) {
686687
const executable = resolverService.resolve(activeWorkspace, shellLaunchConfig.executable);
687688
let resolvedArgs: string[] | string = [];
@@ -698,7 +699,7 @@ export class TerminalProviderChannel implements IServerChannel<RemoteAgentConnec
698699
const executable = terminalEnvironment.getDefaultShell(
699700
(key) => args.configuration[key],
700701
args.isWorkspaceShellAllowed,
701-
getSystemShell(platform.platform),
702+
await getSystemShell(platform.platform),
702703
process.env.hasOwnProperty('PROCESSOR_ARCHITEW6432'),
703704
process.env.windir,
704705
resolver,

0 commit comments

Comments
 (0)