@@ -30,7 +30,7 @@ import * as terminal from 'vs/workbench/contrib/terminal/common/remoteTerminalCh
30
30
import { IShellLaunchConfig , ITerminalEnvironment , ITerminalLaunchError } from 'vs/workbench/contrib/terminal/common/terminal' ;
31
31
import { TerminalDataBufferer } from 'vs/workbench/contrib/terminal/common/terminalDataBuffering' ;
32
32
import * as terminalEnvironment from 'vs/workbench/contrib/terminal/common/terminalEnvironment' ;
33
- import { getSystemShell } from 'vs/workbench/contrib/terminal/ node/terminal ' ;
33
+ import { getSystemShell } from 'vs/base/ node/shell ' ;
34
34
import { getMainProcessParentEnv } from 'vs/workbench/contrib/terminal/node/terminalEnvironment' ;
35
35
import { TerminalProcess } from 'vs/workbench/contrib/terminal/node/terminalProcess' ;
36
36
import { AbstractVariableResolverService } from 'vs/workbench/services/configurationResolver/common/variableResolver' ;
@@ -263,6 +263,7 @@ export class ExtensionEnvironmentChannel implements IServerChannel {
263
263
workspaceStorageHome : this . environment . workspaceStorageHome ,
264
264
userHome : this . environment . userHome ,
265
265
os : platform . OS ,
266
+ marks : [ ]
266
267
} ;
267
268
}
268
269
@@ -681,7 +682,7 @@ export class TerminalProviderChannel implements IServerChannel<RemoteAgentConnec
681
682
const resolverService = new VariableResolverService ( remoteAuthority , args , process . env as platform . IProcessEnvironment ) ;
682
683
const resolver = terminalEnvironment . createVariableResolver ( activeWorkspace , resolverService ) ;
683
684
684
- const getDefaultShellAndArgs = ( ) : { executable : string ; args : string [ ] | string } => {
685
+ const getDefaultShellAndArgs = async ( ) : Promise < { executable : string ; args : string [ ] | string } > => {
685
686
if ( shellLaunchConfig . executable ) {
686
687
const executable = resolverService . resolve ( activeWorkspace , shellLaunchConfig . executable ) ;
687
688
let resolvedArgs : string [ ] | string = [ ] ;
@@ -698,7 +699,7 @@ export class TerminalProviderChannel implements IServerChannel<RemoteAgentConnec
698
699
const executable = terminalEnvironment . getDefaultShell (
699
700
( key ) => args . configuration [ key ] ,
700
701
args . isWorkspaceShellAllowed ,
701
- getSystemShell ( platform . platform ) ,
702
+ await getSystemShell ( platform . platform ) ,
702
703
process . env . hasOwnProperty ( 'PROCESSOR_ARCHITEW6432' ) ,
703
704
process . env . windir ,
704
705
resolver ,
0 commit comments