Skip to content

Commit 34189e4

Browse files
committed
fix(lib/vscode): add getAppRoot to VariableResolverService
Not sure if it's used because it can return undefined, but it's there now!
1 parent dc08bc6 commit 34189e4

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

lib/vscode/src/vs/server/node/channel.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,13 @@ class VariableResolverService extends AbstractVariableResolverService {
350350
getConfigurationValue: (_: URI, section: string): string | undefined => {
351351
return args.resolvedVariables[`config:${section}`];
352352
},
353+
getAppRoot: (): string | undefined => {
354+
/*
355+
NOTE@coder: not sure where we could get this from. This is new.
356+
@jsjoeio 3/11/21
357+
*/
358+
return undefined
359+
},
353360
getExecPath: (): string | undefined => {
354361
// Assuming that resolverEnv is just for use in the resolver and not for
355362
// the terminal itself.

lib/vscode/src/vs/server/node/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { Emitter } from 'vs/base/common/event';
77
import { Schemas } from 'vs/base/common/network';
88
import { URI } from 'vs/base/common/uri';
99
import { getMachineId } from 'vs/base/node/id';
10-
import { ClientConnectionEvent, IPCServer, IServerChannel, ProxyChannel, StaticRouter } from 'vs/base/parts/ipc/common/ipc';
10+
import { ClientConnectionEvent, IPCServer, IServerChannel, ProxyChannel } from 'vs/base/parts/ipc/common/ipc';
1111
import { LogsDataCleaner } from 'vs/code/electron-browser/sharedProcess/contrib/logsDataCleaner';
1212
import { main } from 'vs/code/node/cliProcessMain';
1313
import { IConfigurationService } from 'vs/platform/configuration/common/configuration';

0 commit comments

Comments
 (0)