Skip to content

Commit c2be0ec

Browse files
committed
Fix Firefox when using extensions that insert styles
1 parent ccc4f87 commit c2be0ec

File tree

1 file changed

+17
-1
lines changed

1 file changed

+17
-1
lines changed

scripts/vscode.patch

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -761,7 +761,7 @@ index 622bb7889b..66dd4b0bbc 100644
761761

762762
self.addEventListener('message', event => {
763763
diff --git a/src/vs/workbench/contrib/resources/browser/resourceServiceWorkerClient.ts b/src/vs/workbench/contrib/resources/browser/resourceServiceWorkerClient.ts
764-
index dfda6a1cfb..9bd1aa3e64 100644
764+
index dfda6a1cfb..2b36d35608 100644
765765
--- a/src/vs/workbench/contrib/resources/browser/resourceServiceWorkerClient.ts
766766
+++ b/src/vs/workbench/contrib/resources/browser/resourceServiceWorkerClient.ts
767767
@@ -24,7 +24,11 @@ const _serviceWorker = new class ServiceWorkerStarter {
@@ -777,6 +777,22 @@ index dfda6a1cfb..9bd1aa3e64 100644
777777
// console.debug('SW#reg', reg);
778778
return reg.update();
779779
// }).then(() => {
780+
@@ -108,6 +112,7 @@ class ResourceServiceWorker {
781+
if (!el.sheet) {
782+
continue;
783+
}
784+
+ try {
785+
const rules = (<CSSStyleSheet>el.sheet).rules;
786+
for (let j = 0; j < rules.length; j++) {
787+
const rule = rules[j];
788+
@@ -118,6 +123,7 @@ class ResourceServiceWorker {
789+
updateCount += 1;
790+
}
791+
}
792+
+ } catch (error) {/* Firefox errors if trying to modify style elements inserted by extensions. */}
793+
}
794+
795+
// find any tag using remote uris
780796
diff --git a/src/vs/workbench/contrib/update/electron-browser/update.contribution.ts b/src/vs/workbench/contrib/update/electron-browser/update.contribution.ts
781797
index e39fa57979..3c775c9a06 100644
782798
--- a/src/vs/workbench/contrib/update/electron-browser/update.contribution.ts

0 commit comments

Comments
 (0)