Skip to content

Commit d1ad3fa

Browse files
committed
fix(lib/vscode): update storageService getStorage methods
This change refactors a lot of the get methods in the storageService. I think it simplies a lot. It removes a bunch of methods.
1 parent 325f21f commit d1ad3fa

File tree

1 file changed

+0
-27
lines changed

1 file changed

+0
-27
lines changed

lib/vscode/src/vs/platform/storage/node/storageService.ts

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -153,35 +153,8 @@ export class NativeStorageService extends AbstractStorageService {
153153
}
154154
}
155155

156-
<<<<<<< HEAD
157-
get(key: string, scope: StorageScope, fallbackValue: string): string;
158-
get(key: string, scope: StorageScope): string | undefined;
159-
get(key: string, scope: StorageScope, fallbackValue?: string): string | undefined {
160-
return this.getStorage(scope).get(key, fallbackValue);
161-
}
162-
163-
getBoolean(key: string, scope: StorageScope, fallbackValue: boolean): boolean;
164-
getBoolean(key: string, scope: StorageScope): boolean | undefined;
165-
getBoolean(key: string, scope: StorageScope, fallbackValue?: boolean): boolean | undefined {
166-
return this.getStorage(scope).getBoolean(key, fallbackValue);
167-
}
168-
169-
getNumber(key: string, scope: StorageScope, fallbackValue: number): number;
170-
getNumber(key: string, scope: StorageScope): number | undefined;
171-
getNumber(key: string, scope: StorageScope, fallbackValue?: number): number | undefined {
172-
return this.getStorage(scope).getNumber(key, fallbackValue);
173-
}
174-
175-
protected doStore(key: string, value: string | boolean | number | undefined | null, scope: StorageScope): Promise<void> {
176-
return this.getStorage(scope).set(key, value);
177-
}
178-
179-
protected doRemove(key: string, scope: StorageScope): void {
180-
this.getStorage(scope).delete(key);
181-
=======
182156
protected getStorage(scope: StorageScope): IStorage | undefined {
183157
return scope === StorageScope.GLOBAL ? this.globalStorage : this.workspaceStorage;
184-
>>>>>>> e8cd17a97d8c58fffcbac05394b3ee2b3c72d384
185158
}
186159

187160
protected getLogDetails(scope: StorageScope): string | undefined {

0 commit comments

Comments
 (0)