add app group entitlement

Author: ethanndickson

Coder Desktop/Coder Desktop.xcodeproj/project.pbxproj

@@ -217,6 +217,13 @@
 			);
 			target = 9616792F2CFF117300B2B6DF /* VPN */;
 		};
+		AAC385C72D4339C600F6DFB4 /* Exceptions for "Coder Desktop" folder in "Coder Desktop" target */ = {
+			isa = PBXFileSystemSynchronizedBuildFileExceptionSet;
+			membershipExceptions = (
+				Info.plist,
+			);
+			target = 961678FB2CFF100D00B2B6DF /* Coder Desktop */;
+		};
 /* End PBXFileSystemSynchronizedBuildFileExceptionSet section */
 
 /* Begin PBXFileSystemSynchronizedRootGroup section */
@@ -230,6 +237,9 @@
 		};
 		961678FE2CFF100D00B2B6DF /* Coder Desktop */ = {
 			isa = PBXFileSystemSynchronizedRootGroup;
+			exceptions = (
+				AAC385C72D4339C600F6DFB4 /* Exceptions for "Coder Desktop" folder in "Coder Desktop" target */,
+			);
 			path = "Coder Desktop";
 			sourceTree = "<group>";
 		};
@@ -994,7 +1004,7 @@
 				DYLIB_COMPATIBILITY_VERSION = 1;
 				DYLIB_CURRENT_VERSION = 1;
 				DYLIB_INSTALL_NAME_BASE = "@rpath";
-				ENABLE_MODULE_VERIFIER = YES;
+				ENABLE_MODULE_VERIFIER = NO;
 				GENERATE_INFOPLIST_FILE = YES;
 				INFOPLIST_KEY_NSHumanReadableCopyright = "";
 				INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
@@ -1396,7 +1406,7 @@
 				DYLIB_COMPATIBILITY_VERSION = 1;
 				DYLIB_CURRENT_VERSION = 1;
 				DYLIB_INSTALL_NAME_BASE = "@rpath";
-				ENABLE_MODULE_VERIFIER = YES;
+				ENABLE_MODULE_VERIFIER = NO;
 				GENERATE_INFOPLIST_FILE = YES;
 				INFOPLIST_KEY_NSHumanReadableCopyright = "";
 				INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
@@ -1506,7 +1516,7 @@
 				DYLIB_COMPATIBILITY_VERSION = 1;
 				DYLIB_CURRENT_VERSION = 1;
 				DYLIB_INSTALL_NAME_BASE = "@rpath";
-				ENABLE_MODULE_VERIFIER = YES;
+				ENABLE_MODULE_VERIFIER = NO;
 				GENERATE_INFOPLIST_FILE = YES;
 				INFOPLIST_KEY_NSHumanReadableCopyright = "";
 				INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";

Coder Desktop/Coder Desktop/Coder_Desktop.entitlements

@@ -10,6 +10,10 @@
 	<true/>
 	<key>com.apple.security.app-sandbox</key>
 	<true/>
+	<key>com.apple.security.application-groups</key>
+	<array>
+		<string>$(TeamIdentifierPrefix)com.coder.Coder-Desktop</string>
+	</array>
 	<key>com.apple.security.files.user-selected.read-only</key>
 	<true/>
 	<key>com.apple.security.network.client</key>

Coder Desktop/Coder Desktop/VPNService.swift

@@ -69,7 +69,7 @@ final class CoderVPNService: NSObject, VPNService, @preconcurrency VPNXPCClientC
     override init() {
         let networkExtDict = Bundle.main.object(forInfoDictionaryKey: "NetworkExtension") as? [String: Any]
         let machServiceName = networkExtDict?["NEMachServiceName"] as? String
-        xpcConn = NSXPCConnection(serviceName: machServiceName!)
+        xpcConn = NSXPCConnection(machServiceName: machServiceName!)
         xpcConn.remoteObjectInterface = NSXPCInterface(with: VPNXPCProtocol.self)
         xpcConn.exportedInterface = NSXPCInterface(with: VPNXPCClientCallbackProtocol.self)
 

Coder Desktop/VPN/PacketTunnelProvider.swift

@@ -65,9 +65,9 @@ class PacketTunnelProvider: NEPacketTunnelProvider, @unchecked Sendable {
                 logger.debug("calling manager.startVPN")
                 try await manager!.startVPN()
                 logger.debug("vpn started")
-                completionHandler.callAsFunction(nil)
+                completionHandler(nil)
             } catch {
-                completionHandler.callAsFunction(error as NSError)
+                completionHandler(error as NSError)
                 logger.error("error starting manager: \(error.description, privacy: .public)")
             }
         }