PR review + fmt

Author: ibetitsmike

App/Services/SettingsManager.cs

@@ -82,7 +82,7 @@ public SettingsManager(string? settingsFilePath = null)
         Directory.CreateDirectory(folder);
         _settingsFilePath = Path.Combine(folder, _fileName);
 
-        if(!File.Exists(_settingsFilePath))
+        if (!File.Exists(_settingsFilePath))
         {
             // Create the settings file if it doesn't exist
             string emptyJson = JsonSerializer.Serialize(new { });

App/ViewModels/SettingsViewModel.cs

@@ -35,44 +35,46 @@ public SettingsViewModel(ILogger<SettingsViewModel> logger, ISettingsManager set
         // We disable the option in the UI if the policy is set.
         StartOnLoginDisabled = _startupManager.IsDisabledByPolicy();
 
-        this.PropertyChanged += (_, args) =>
+        // Ensure the StartOnLogin property matches the current startup state.
+        if (StartOnLogin != _startupManager.IsEnabled())
+        {
+            StartOnLogin = _startupManager.IsEnabled();
+        }
+    }
+
+    partial void OnConnectOnLaunchChanged(bool oldValue, bool newValue)
+    {
+        if (oldValue == newValue)
+            return;
+        try
+        {
+            _settingsManager.ConnectOnLaunch = ConnectOnLaunch;
+        }
+        catch (Exception ex)
         {
-            if (args.PropertyName == nameof(ConnectOnLaunch))
+            _logger.LogError($"Error saving {SettingsManager.ConnectOnLaunchKey} setting: {ex.Message}");
+        }
+    }
+
+    partial void OnStartOnLoginChanged(bool oldValue, bool newValue)
+    {
+        if (oldValue == newValue)
+            return;
+        try
+        {
+            _settingsManager.StartOnLogin = StartOnLogin;
+            if (StartOnLogin)
             {
-                try
-                {
-                    _settingsManager.ConnectOnLaunch = ConnectOnLaunch;
-                }
-                catch (Exception ex)
-                {
-                    _logger.LogError($"Error saving {SettingsManager.ConnectOnLaunchKey} setting: {ex.Message}");
-                }
+                _startupManager.Enable();
             }
-            else if (args.PropertyName == nameof(StartOnLogin))
+            else
             {
-                try
-                {
-                    _settingsManager.StartOnLogin = StartOnLogin;
-                    if (StartOnLogin)
-                    {
-                        _startupManager.Enable();
-                    }
-                    else
-                    {
-                        _startupManager.Disable();
-                    }
-                }
-                catch (Exception ex)
-                {
-                    _logger.LogError($"Error saving {SettingsManager.StartOnLoginKey} setting: {ex.Message}");
-                }
+                _startupManager.Disable();
             }
-        };
-
-        // Ensure the StartOnLogin property matches the current startup state.
-        if (StartOnLogin != _startupManager.IsEnabled())
+        }
+        catch (Exception ex)
         {
-            StartOnLogin = _startupManager.IsEnabled();
+            _logger.LogError($"Error saving {SettingsManager.StartOnLoginKey} setting: {ex.Message}");
         }
     }
 }

App/Views/Pages/SettingsMainPage.xaml.cs

@@ -9,7 +9,7 @@ public sealed partial class SettingsMainPage : Page
 
     public SettingsMainPage(SettingsViewModel viewModel)
     {
-        ViewModel = viewModel; // already initialized
+        ViewModel = viewModel;
         InitializeComponent();
     }
 }