PR comments

Author: deansheather

App/Services/MutagenController.cs

@@ -538,44 +538,25 @@ private void StartDaemonProcess()
         Directory.CreateDirectory(_mutagenDataDirectory);
         var logPath = Path.Combine(_mutagenDataDirectory, "daemon.log");
         var logStream = new StreamWriter(logPath, true);
-        try
-        {
-            _daemonProcess = new Process();
-            _daemonProcess.StartInfo.FileName = _mutagenExecutablePath;
-            _daemonProcess.StartInfo.Arguments = "daemon run";
-            _daemonProcess.StartInfo.Environment.Add("MUTAGEN_DATA_DIRECTORY", _mutagenDataDirectory);
-            // hide the console window
-            _daemonProcess.StartInfo.CreateNoWindow = true;
-            // shell needs to be disabled since we set the environment
-            // https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.processstartinfo.environment?view=net-8.0
-            _daemonProcess.StartInfo.UseShellExecute = false;
-            _daemonProcess.StartInfo.RedirectStandardError = true;
-            // TODO: log exited process
-            // _daemonProcess.Exited += ...
-            if (!_daemonProcess.Start())
-                throw new InvalidOperationException("Failed to start mutagen daemon process, Start returned false");
-
-            var writer = new LogWriter(_daemonProcess.StandardError, logStream);
-            Task.Run(() => { _ = writer.Run(); });
-            _logWriter = writer;
-        }
-        catch
-        {
-            try
-            {
-                _daemonProcess?.Kill();
-            }
-            catch
-            {
-                // ignored
-            }
 
-            _daemonProcess?.Dispose();
-            _logWriter?.Dispose();
-            _daemonProcess = null;
-            _logWriter = null;
-            throw;
-        }
+        _daemonProcess = new Process();
+        _daemonProcess.StartInfo.FileName = _mutagenExecutablePath;
+        _daemonProcess.StartInfo.Arguments = "daemon run";
+        _daemonProcess.StartInfo.Environment.Add("MUTAGEN_DATA_DIRECTORY", _mutagenDataDirectory);
+        // hide the console window
+        _daemonProcess.StartInfo.CreateNoWindow = true;
+        // shell needs to be disabled since we set the environment
+        // https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.processstartinfo.environment?view=net-8.0
+        _daemonProcess.StartInfo.UseShellExecute = false;
+        _daemonProcess.StartInfo.RedirectStandardError = true;
+        // TODO: log exited process
+        // _daemonProcess.Exited += ...
+        if (!_daemonProcess.Start())
+            throw new InvalidOperationException("Failed to start mutagen daemon process, Start returned false");
+
+        var writer = new LogWriter(_daemonProcess.StandardError, logStream);
+        Task.Run(() => { _ = writer.Run(); });
+        _logWriter = writer;
     }
 
     /// <summary>

App/ViewModels/DirectoryPickerViewModel.cs

@@ -219,7 +219,7 @@ private void ProcessResponse(ListDirectoryResponse res)
         {
             new()
             {
-                Name = "(root)",
+                Name = "🖥️",
                 AbsolutePathSegments = [],
                 IsFirst = true,
                 ViewModel = this,

App/ViewModels/FileSyncListViewModel.cs

@@ -284,7 +284,9 @@ private void SetAvailableHostsFromRpcModel(RpcModel rpcModel)
     private void StartCreatingNewSession()
     {
         ClearNewForm();
-        // Ensure we have a fresh hosts list before we open the form.
+        // Ensure we have a fresh hosts list before we open the form. We don't
+        // bind directly to the list on RPC state updates as updating the list
+        // while in use seems to break it.
         SetAvailableHostsFromRpcModel(_rpcController.GetState());
         CreatingNewSession = true;
     }

Tests.App/Services/CredentialManagerTest.cs

@@ -1,6 +1,7 @@
 using System.Diagnostics;
 using Coder.Desktop.App.Models;
 using Coder.Desktop.App.Services;
+using Coder.Desktop.CoderSdk.Coder;
 using Moq;
 
 namespace Coder.Desktop.Tests.App.Services;