chore: PR comments

Author: deansheather

App/App.xaml.cs

@@ -1,7 +1,7 @@
 using System;
 using System.Diagnostics;
-using Coder.Desktop.App.Models;
 using Coder.Desktop.App.Services;
+using Coder.Desktop.App.ViewModels;
 using Coder.Desktop.App.Views;
 using Coder.Desktop.App.Views.Pages;
 using Microsoft.Extensions.DependencyInjection;

App/Converters/AgentStatusToColorConverter.cs

@@ -0,0 +1,31 @@
+using System;
+using Windows.UI;
+using Coder.Desktop.App.ViewModels;
+using Microsoft.UI.Xaml.Data;
+using Microsoft.UI.Xaml.Media;
+
+namespace Coder.Desktop.App.Converters;
+
+public class AgentStatusToColorConverter : IValueConverter
+{
+    private static readonly SolidColorBrush Green = new(Color.FromArgb(255, 52, 199, 89));
+    private static readonly SolidColorBrush Red = new(Color.FromArgb(255, 255, 59, 48));
+    private static readonly SolidColorBrush Gray = new(Color.FromArgb(255, 142, 142, 147));
+
+    public object Convert(object value, Type targetType, object parameter, string language)
+    {
+        if (value is not AgentConnectionStatus status) return Gray;
+
+        return status switch
+        {
+            AgentConnectionStatus.Green => Green,
+            AgentConnectionStatus.Red => Red,
+            _ => Gray,
+        };
+    }
+
+    public object ConvertBack(object value, Type targetType, object parameter, string language)
+    {
+        throw new NotImplementedException();
+    }
+}

App/Converters/VpnLifecycleToBoolConverter.cs

@@ -0,0 +1,33 @@
+using System;
+using Coder.Desktop.App.Models;
+using DependencyPropertyGenerator;
+using Microsoft.UI.Xaml;
+using Microsoft.UI.Xaml.Data;
+
+namespace Coder.Desktop.App.Converters;
+
+[DependencyProperty<bool>("Starting", DefaultValue = false)]
+[DependencyProperty<bool>("Started", DefaultValue = false)]
+[DependencyProperty<bool>("Stopping", DefaultValue = false)]
+[DependencyProperty<bool>("Stopped", DefaultValue = false)]
+public partial class VpnLifecycleToBoolConverter : DependencyObject, IValueConverter
+{
+    public object Convert(object value, Type targetType, object parameter, string language)
+    {
+        if (value is not VpnLifecycle lifecycle) return Stopped;
+
+        return lifecycle switch
+        {
+            VpnLifecycle.Starting => Starting,
+            VpnLifecycle.Started => Started,
+            VpnLifecycle.Stopping => Stopping,
+            VpnLifecycle.Stopped => Stopped,
+            _ => Visibility.Collapsed,
+        };
+    }
+
+    public object ConvertBack(object value, Type targetType, object parameter, string language)
+    {
+        throw new NotImplementedException();
+    }
+}

App/Converters/VpnLifecycleToVisibilityConverter.cs

@@ -0,0 +1,14 @@
+using System;
+using Microsoft.UI.Xaml;
+using Microsoft.UI.Xaml.Data;
+
+namespace Coder.Desktop.App.Converters;
+
+public partial class VpnLifecycleToVisibilityConverter : VpnLifecycleToBoolConverter, IValueConverter
+{
+    public new object Convert(object value, Type targetType, object parameter, string language)
+    {
+        var boolValue = base.Convert(value, targetType, parameter, language);
+        return boolValue is true ? Visibility.Visible : Visibility.Collapsed;
+    }
+}

App/Models/AgentModel.cs

@@ -23,16 +23,15 @@ public class RpcModel
 
     public VpnLifecycle VpnLifecycle { get; set; } = VpnLifecycle.Stopped;
 
-    // TODO: write a type for this or maybe use the Rpc Type directly
-    public List<object> VisibleAgents { get; set; } = [];
+    public List<object> Agents { get; set; } = [];
 
     public RpcModel Clone()
     {
         return new RpcModel
         {
             RpcLifecycle = RpcLifecycle,
             VpnLifecycle = VpnLifecycle,
-            VisibleAgents = VisibleAgents,
+            Agents = Agents,
         };
     }
 }

App/Models/RpcModel.cs

@@ -58,7 +58,6 @@ public async Task SetCredentials(string coderUrl, string apiToken, CancellationT
         if (coderUrl.Length > 128) throw new ArgumentOutOfRangeException(nameof(coderUrl), "Coder URL is too long");
         if (!Uri.TryCreate(coderUrl, UriKind.Absolute, out var uri))
             throw new ArgumentException($"Coder URL '{coderUrl}' is not a valid URL", nameof(coderUrl));
-        if (uri.Scheme != "https") throw new ArgumentException("Coder URL must use HTTPS", nameof(coderUrl));
         if (uri.PathAndQuery != "/") throw new ArgumentException("Coder URL must be the root URL", nameof(coderUrl));
         if (string.IsNullOrWhiteSpace(apiToken)) throw new ArgumentException("API token is required", nameof(apiToken));
         apiToken = apiToken.Trim();
@@ -105,11 +104,15 @@ public void ClearCredentials()
 
     private void UpdateState(CredentialModel newModel)
     {
-        _latestCredentials = newModel;
-        CredentialsChanged?.Invoke(this, _latestCredentials.Clone());
+        using (_lock.Lock())
+        {
+            _latestCredentials = newModel.Clone();
+        }
+
+        CredentialsChanged?.Invoke(this, newModel.Clone());
     }
 
-    private RawCredentials? ReadCredentials()
+    private static RawCredentials? ReadCredentials()
     {
         var raw = NativeApi.ReadCredentials(CredentialsTargetName);
         if (raw == null) return null;
@@ -130,7 +133,7 @@ private void UpdateState(CredentialModel newModel)
         return credentials;
     }
 
-    private void WriteCredentials(RawCredentials credentials)
+    private static void WriteCredentials(RawCredentials credentials)
     {
         var raw = JsonSerializer.Serialize(credentials);
         NativeApi.WriteCredentials(CredentialsTargetName, raw);
@@ -147,6 +150,7 @@ private static class NativeApi
         private const int CredentialTypeGeneric = 1;
         private const int PersistenceTypeLocalComputer = 2;
         private const int ErrorNotFound = 1168;
+        private const int CredMaxCredentialBlobSize = 5 * 512;
 
         public static string? ReadCredentials(string targetName)
         {
@@ -170,15 +174,17 @@ private static class NativeApi
 
         public static void WriteCredentials(string targetName, string secret)
         {
-            if (Encoding.Unicode.GetByteCount(secret) > 512)
-                throw new ArgumentOutOfRangeException(nameof(secret), "The secret is greater than 512 bytes");
+            var byteCount = Encoding.Unicode.GetByteCount(secret);
+            if (byteCount > CredMaxCredentialBlobSize)
+                throw new ArgumentOutOfRangeException(nameof(secret),
+                    $"The secret is greater than {CredMaxCredentialBlobSize} bytes");
 
             var credentialBlob = Marshal.StringToHGlobalUni(secret);
             var cred = new CREDENTIAL
             {
                 Type = CredentialTypeGeneric,
                 TargetName = targetName,
-                CredentialBlobSize = secret.Length * sizeof(char),
+                CredentialBlobSize = byteCount,
                 CredentialBlob = credentialBlob,
                 Persist = PersistenceTypeLocalComputer,
             };

App/Services/CredentialManager.cs

@@ -96,13 +96,13 @@ public async Task Reconnect(CancellationToken ct = default)
         {
             state.RpcLifecycle = RpcLifecycle.Connecting;
             state.VpnLifecycle = VpnLifecycle.Stopped;
-            state.VisibleAgents.Clear();
+            state.Agents.Clear();
         });
 
         if (_speaker != null)
             try
             {
-                await _speaker.DisposeAsync();
+                await DisposeSpeaker();
             }
             catch (Exception e)
             {
@@ -126,7 +126,7 @@ public async Task Reconnect(CancellationToken ct = default)
             {
                 state.RpcLifecycle = RpcLifecycle.Disconnected;
                 state.VpnLifecycle = VpnLifecycle.Stopped;
-                state.VisibleAgents.Clear();
+                state.Agents.Clear();
             });
             throw new RpcOperationException("Failed to reconnect to the RPC server", e);
         }
@@ -136,14 +136,14 @@ public async Task Reconnect(CancellationToken ct = default)
             state.RpcLifecycle = RpcLifecycle.Connected;
             // TODO: fetch current state
             state.VpnLifecycle = VpnLifecycle.Stopped;
-            state.VisibleAgents.Clear();
+            state.Agents.Clear();
         });
     }
 
     public async Task StartVpn(CancellationToken ct = default)
     {
         using var _ = await AcquireOperationLockNowAsync();
-        EnsureRpcConnected();
+        AssertRpcConnected();
 
         var credentials = _credentialManager.GetCredentials();
         if (credentials.State != CredentialState.Valid)
@@ -184,7 +184,7 @@ public async Task StartVpn(CancellationToken ct = default)
     public async Task StopVpn(CancellationToken ct = default)
     {
         using var _ = await AcquireOperationLockNowAsync();
-        EnsureRpcConnected();
+        AssertRpcConnected();
 
         MutateState(state => { state.VpnLifecycle = VpnLifecycle.Stopping; });
 
@@ -216,9 +216,14 @@ public async Task StopVpn(CancellationToken ct = default)
 
     private void MutateState(Action<RpcModel> mutator)
     {
-        using var _ = _stateLock.Lock();
-        mutator(_state);
-        StateChanged?.Invoke(this, _state.Clone());
+        RpcModel newState;
+        using (_stateLock.Lock())
+        {
+            mutator(_state);
+            newState = _state.Clone();
+        }
+
+        StateChanged?.Invoke(this, newState);
     }
 
     private async Task<IDisposable> AcquireOperationLockNowAsync()
@@ -234,13 +239,22 @@ private void SpeakerOnReceive(ReplyableRpcMessage<ClientMessage, ServiceMessage>
         // TODO: this
     }
 
+    private async Task DisposeSpeaker()
+    {
+        if (_speaker == null) return;
+        _speaker.Receive -= SpeakerOnReceive;
+        _speaker.Error -= SpeakerOnError;
+        await _speaker.DisposeAsync();
+        _speaker = null;
+    }
+
     private void SpeakerOnError(Exception e)
     {
         Debug.WriteLine($"Error: {e}");
         Reconnect(CancellationToken.None).Wait();
     }
 
-    private void EnsureRpcConnected()
+    private void AssertRpcConnected()
     {
         if (_speaker == null)
             throw new InvalidOperationException("Not connected to the RPC server");

App/Services/RpcController.cs

@@ -0,0 +1,51 @@
+using Windows.ApplicationModel.DataTransfer;
+using CommunityToolkit.Mvvm.Input;
+using Microsoft.UI.Xaml;
+using Microsoft.UI.Xaml.Controls;
+using Microsoft.UI.Xaml.Controls.Primitives;
+
+namespace Coder.Desktop.App.ViewModels;
+
+public enum AgentConnectionStatus
+{
+    Green,
+    Red,
+    Gray,
+}
+
+public partial class AgentViewModel
+{
+    public required string Hostname { get; set; }
+
+    public required string HostnameSuffix { get; set; } // including leading dot
+
+    public required AgentConnectionStatus ConnectionStatus { get; set; }
+
+    public string FullHostname => Hostname + HostnameSuffix;
+
+    public required string DashboardUrl { get; set; }
+
+    [RelayCommand]
+    private void CopyHostname(object parameter)
+    {
+        var dataPackage = new DataPackage
+        {
+            RequestedOperation = DataPackageOperation.Copy,
+        };
+        dataPackage.SetText(FullHostname);
+        Clipboard.SetContent(dataPackage);
+
+        if (parameter is not FrameworkElement frameworkElement) return;
+
+        var flyout = new Flyout
+        {
+            Content = new TextBlock
+            {
+                Text = "DNS Copied",
+                Margin = new Thickness(4),
+            },
+        };
+        FlyoutBase.SetAttachedFlyout(frameworkElement, flyout);
+        FlyoutBase.ShowAttachedFlyout(frameworkElement);
+    }
+}

App/ViewModels/AgentViewModel.cs

@@ -1,9 +1,10 @@
 using System.Threading.Tasks;
+using Coder.Desktop.App.Models;
 using Coder.Desktop.App.Services;
 using CommunityToolkit.Mvvm.ComponentModel;
 using CommunityToolkit.Mvvm.Input;
 
-namespace Coder.Desktop.App.Models;
+namespace Coder.Desktop.App.ViewModels;
 
 public partial class TrayWindowDisconnectedViewModel : ObservableObject
 {