added StartupManager to handle auto-start

changed order of CredentialManager loading

Author: ibetitsmike

App/App.xaml.cs

@@ -138,6 +138,25 @@ public async Task ExitApplication()
     protected override void OnLaunched(LaunchActivatedEventArgs args)
     {
         _logger.LogInformation("new instance launched");
+
+        // Load the credentials in the background.
+        var credentialManagerCts = new CancellationTokenSource(TimeSpan.FromSeconds(15));
+        var credentialManager = _services.GetRequiredService<ICredentialManager>();
+        credentialManager.LoadCredentials(credentialManagerCts.Token).ContinueWith(t =>
+        {
+            if (t.Exception != null)
+            {
+                _logger.LogError(t.Exception, "failed to load credentials");
+#if DEBUG
+                Debug.WriteLine(t.Exception);
+                Debugger.Break();
+#endif
+            }
+
+            credentialManagerCts.Dispose();
+        });
+
+
         // Start connecting to the manager in the background.
         var rpcController = _services.GetRequiredService<IRpcController>();
         if (rpcController.GetState().RpcLifecycle == RpcLifecycle.Disconnected)
@@ -155,7 +174,7 @@ protected override void OnLaunched(LaunchActivatedEventArgs args)
 #endif
             } else
             {
-                if (rpcController.GetState().RpcLifecycle == RpcLifecycle.Disconnected)
+                if (rpcController.GetState().VpnLifecycle == VpnLifecycle.Stopped)
                 {
                     if (_settingsManager.Read(SettingsManager.ConnectOnLaunchKey, false))
                     {
@@ -172,23 +191,6 @@ protected override void OnLaunched(LaunchActivatedEventArgs args)
             }
         });
 
-        // Load the credentials in the background.
-        var credentialManagerCts = new CancellationTokenSource(TimeSpan.FromSeconds(15));
-        var credentialManager = _services.GetRequiredService<ICredentialManager>();
-        _ = credentialManager.LoadCredentials(credentialManagerCts.Token).ContinueWith(t =>
-        {
-            if (t.Exception != null)
-            {
-                _logger.LogError(t.Exception, "failed to load credentials");
-#if DEBUG
-                Debug.WriteLine(t.Exception);
-                Debugger.Break();
-#endif
-            }
-
-            credentialManagerCts.Dispose();
-        }, CancellationToken.None);
-
         // Initialize file sync.
         var syncSessionCts = new CancellationTokenSource(TimeSpan.FromSeconds(10));
         var syncSessionController = _services.GetRequiredService<ISyncSessionController>();

App/Services/SettingsManager.cs

@@ -1,10 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
-using System.Linq;
-using System.Text;
 using System.Text.Json;
-using System.Threading.Tasks;
 
 namespace Coder.Desktop.App.Services;
 /// <summary>

App/Services/StartupManager.cs

@@ -0,0 +1,73 @@
+using Microsoft.Win32;
+using System;
+using System.Diagnostics;
+using System.Security;
+
+namespace Coder.Desktop.App.Services;
+public static class StartupManager
+{
+    private const string RunKey = @"Software\\Microsoft\\Windows\\CurrentVersion\\Run";
+    private const string PoliciesExplorerUser = @"Software\\Microsoft\\Windows\\CurrentVersion\\Policies\\Explorer";
+    private const string PoliciesExplorerMachine = @"SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Policies\\Explorer";
+    private const string DisableCurrentUserRun = "DisableCurrentUserRun";
+    private const string DisableLocalMachineRun = "DisableLocalMachineRun";
+
+    private const string _defaultValueName = "CoderDesktopApp";
+
+    /// <summary>
+    /// Adds the current executable to the per‑user Run key. Returns <c>true</c> if successful.
+    /// Fails (returns <c>false</c>) when blocked by policy or lack of permissions.
+    /// </summary>
+    public static bool Enable()
+    {
+        if (IsDisabledByPolicy())
+            return false;
+
+        string exe = Process.GetCurrentProcess().MainModule!.FileName;
+        try
+        {
+            using var key = Registry.CurrentUser.OpenSubKey(RunKey, writable: true)
+                            ?? Registry.CurrentUser.CreateSubKey(RunKey)!;
+            key.SetValue(_defaultValueName, $"\"{exe}\"");
+            return true;
+        }
+        catch (UnauthorizedAccessException) { return false; }
+        catch (SecurityException) { return false; }
+    }
+
+    /// <summary>Removes the value from the Run key (no-op if missing).</summary>
+    public static void Disable()
+    {
+        using var key = Registry.CurrentUser.OpenSubKey(RunKey, writable: true);
+        key?.DeleteValue(_defaultValueName, throwOnMissingValue: false);
+    }
+
+    /// <summary>Checks whether the value exists in the Run key.</summary>
+    public static bool IsEnabled()
+    {
+        using var key = Registry.CurrentUser.OpenSubKey(RunKey);
+        return key?.GetValue(_defaultValueName) != null;
+    }
+
+    /// <summary>
+    /// Detects whether group policy disables per‑user startup programs.
+    /// Mirrors <see cref="Windows.ApplicationModel.StartupTaskState.DisabledByPolicy"/>.
+    /// </summary>
+    public static bool IsDisabledByPolicy()
+    {
+        // User policy – HKCU
+        using (var keyUser = Registry.CurrentUser.OpenSubKey(PoliciesExplorerUser))
+        {
+            if ((int?)keyUser?.GetValue(DisableCurrentUserRun) == 1) return true;
+        }
+        // Machine policy – HKLM
+        using (var keyMachine = Registry.LocalMachine.OpenSubKey(PoliciesExplorerMachine))
+        {
+            if ((int?)keyMachine?.GetValue(DisableLocalMachineRun) == 1) return true;
+        }
+
+        // Some non‑desktop SKUs report DisabledByPolicy implicitly
+        return false;
+    }
+}
+

App/ViewModels/SettingsViewModel.cs

@@ -1,24 +1,22 @@
 using Coder.Desktop.App.Services;
 using CommunityToolkit.Mvvm.ComponentModel;
-using CommunityToolkit.Mvvm.Input;
 using Microsoft.Extensions.Logging;
 using Microsoft.UI.Dispatching;
 using Microsoft.UI.Xaml;
-using Microsoft.UI.Xaml.Controls;
 using System;
 
 namespace Coder.Desktop.App.ViewModels;
 
 public partial class SettingsViewModel : ObservableObject
 {
-    private Window? _window;
-    private DispatcherQueue? _dispatcherQueue;
-
     private readonly ILogger<SettingsViewModel> _logger;
 
     [ObservableProperty]
     public partial bool ConnectOnLaunch { get; set; } = false;
 
+    [ObservableProperty]
+    public partial bool StartOnLoginDisabled { get; set; } = false;
+
     [ObservableProperty]
     public partial bool StartOnLogin { get; set; } = false;
 
@@ -31,6 +29,10 @@ public SettingsViewModel(ILogger<SettingsViewModel> logger, ISettingsManager set
         ConnectOnLaunch = _settingsManager.Read(SettingsManager.ConnectOnLaunchKey, false);
         StartOnLogin = _settingsManager.Read(SettingsManager.StartOnLoginKey, false);
 
+        // Various policies can disable the "Start on login" option.
+        // We disable the option in the UI if the policy is set.
+        StartOnLoginDisabled = StartupManager.IsDisabledByPolicy();
+
         this.PropertyChanged += (_, args) =>
         {
             if (args.PropertyName == nameof(ConnectOnLaunch))
@@ -41,28 +43,34 @@ public SettingsViewModel(ILogger<SettingsViewModel> logger, ISettingsManager set
                 }
                 catch (Exception ex)
                 {
-                    Console.WriteLine($"Error saving {SettingsManager.ConnectOnLaunchKey} setting: {ex.Message}");
+                    _logger.LogError($"Error saving {SettingsManager.ConnectOnLaunchKey} setting: {ex.Message}");
                 }
             }
             else if (args.PropertyName == nameof(StartOnLogin))
             {
                 try
                 {
                     _settingsManager.Save(SettingsManager.StartOnLoginKey, StartOnLogin);
+                    if (StartOnLogin)
+                    {
+                        StartupManager.Enable();
+                    }
+                    else
+                    {
+                        StartupManager.Disable();
+                    }
                 }
                 catch (Exception ex)
                 {
-                    Console.WriteLine($"Error saving {SettingsManager.StartOnLoginKey} setting: {ex.Message}");
+                    _logger.LogError($"Error saving {SettingsManager.StartOnLoginKey} setting: {ex.Message}");
                 }
             }
         };
-    }
 
-    public void Initialize(Window window, DispatcherQueue dispatcherQueue)
-    {
-        _window = window;
-        _dispatcherQueue = dispatcherQueue;
-        if (!_dispatcherQueue.HasThreadAccess)
-            throw new InvalidOperationException("Initialize must be called from the UI thread");
+        // Ensure the StartOnLogin property matches the current startup state.
+        if (StartOnLogin != StartupManager.IsEnabled())
+        {
+            StartOnLogin = StartupManager.IsEnabled();
+        }
     }
 }

App/Views/Pages/SettingsMainPage.xaml

@@ -39,14 +39,16 @@
 
                 <controls:SettingsCard Description="This setting controls whether the Coder Desktop app starts on Windows startup."
                                        Header="Start on login"
-                                       HeaderIcon="{ui:FontIcon Glyph=&#xE819;}">
+                                       HeaderIcon="{ui:FontIcon Glyph=&#xE819;}"
+                                       IsEnabled="{x:Bind ViewModel.StartOnLoginDisabled, Converter={StaticResource InverseBoolConverter}, Mode=OneWay}">
                     <ToggleSwitch IsOn="{x:Bind ViewModel.StartOnLogin, Mode=TwoWay}" />
                 </controls:SettingsCard>
 
                 <TextBlock Style="{StaticResource SettingsSectionHeaderTextBlockStyle}" Text="Coder Connect" />
-                <controls:SettingsCard Description="This setting controls whether Coder Connect automatically starts with Coder Desktop  "
+                <controls:SettingsCard Description="This setting controls whether Coder Connect automatically starts with Coder Desktop. "
                                        Header="Connect on launch"
-                                       HeaderIcon="{ui:FontIcon Glyph=&#xE8AF;}">
+                                       HeaderIcon="{ui:FontIcon Glyph=&#xE8AF;}"
+                                       >
                     <ToggleSwitch IsOn="{x:Bind ViewModel.ConnectOnLaunch, Mode=TwoWay}" />
                 </controls:SettingsCard>
             </StackPanel>

App/Views/SettingsWindow.xaml.cs

@@ -18,7 +18,6 @@ public SettingsWindow(SettingsViewModel viewModel)
 
         SystemBackdrop = new DesktopAcrylicBackdrop();
 
-        ViewModel.Initialize(this, DispatcherQueue);
         RootFrame.Content = new SettingsMainPage(ViewModel);
 
         this.CenterOnScreen();

Tests.App/Services/SettingsManagerTest.cs

@@ -1,9 +1,4 @@
 using Coder.Desktop.App.Services;
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace Coder.Desktop.Tests.App.Services
 {