feat: calculate taskbar position and display on top of it #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this account for opening it from the tray overflow? e.g. from: EDIT: The Logitech app I use does this actually, I don't think I like it What are the downsides of doing it on the cursor position? |
|
My idea was to actually draw it from the taskbar because otherwise it just leaves the tray window floating on your desktop. I clicked this one from the expanded overflow and it painted like this: |
App/Views/TrayWindow.xaml.cs
Outdated
Comment on lines
263
to
281
| case TaskbarPosition.Bottom when tb.AutoHide: | ||
| // Auto-hide bottom bar sits under the workArea – use workArea, not bounds. | ||
| x = workArea.X + workArea.Width - panelSize.Width; | ||
| y = workArea.Y + workArea.Height - panelSize.Height - tb.Gap; | ||
| break; | ||
|
|
||
| // Adjust if the window goes off the top edge of the display (somehow). | ||
| if (y < workArea.Y) y = workArea.Y; | ||
| default: // right or bottom when not auto-hiding | ||
| x = workArea.X + workArea.Width - panelSize.Width; | ||
| y = bounds.Y + bounds.Height - panelSize.Height - tb.Gap; | ||
| break; |
There was a problem hiding this comment.
I don't get why we wouldn't just always use workArea.Height here, the comment doesn't do a very good job explaining why we wouldn't prefer to always use the workArea.Height.
There was a problem hiding this comment.
We could. It's the same thing in that scenario. I've simplified the logic to make it clearer.
ibetitsmike
force-pushed
the
mike/119-tray-window-location-improvements
branch
from
5638bf1 to
c2a748e
Compare
deansheather
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #119